Re: [libvirt] [PATCH] network: fix crash when portgroup has no name

2012-11-29 Thread Martin Kletzander
On 11/28/2012 05:55 PM, Laine Stump wrote: On 11/28/2012 04:19 AM, Martin Kletzander wrote: On 11/28/2012 06:08 AM, Laine Stump wrote: This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=879473 The name attribute is required for portgroup elements (yes, the RNG specifies that), and

Re: [libvirt] [PATCH] network: fix crash when portgroup has no name

2012-11-28 Thread Martin Kletzander
On 11/28/2012 06:08 AM, Laine Stump wrote: This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=879473 The name attribute is required for portgroup elements (yes, the RNG specifies that), and there is code in libvirt that assumes it is non-null. Unfortunately, the portgroup parsing

Re: [libvirt] [PATCH] network: fix crash when portgroup has no name

2012-11-28 Thread Laine Stump
On 11/28/2012 04:19 AM, Martin Kletzander wrote: On 11/28/2012 06:08 AM, Laine Stump wrote: This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=879473 The name attribute is required for portgroup elements (yes, the RNG specifies that), and there is code in libvirt that assumes it is

[libvirt] [PATCH] network: fix crash when portgroup has no name

2012-11-27 Thread Laine Stump
This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=879473 The name attribute is required for portgroup elements (yes, the RNG specifies that), and there is code in libvirt that assumes it is non-null. Unfortunately, the portgroup parsing function wasn't checking for lack of portgroup.