Re: [libvirt] [PATCH] qemu: Refuse to use "ps2" on machines that do not have this bus

2020-01-23 Thread Michal Privoznik
On 1/15/20 1:23 PM, Thomas Huth wrote: The "ps2" bus is only available on certain machines like x86. On machines like s390x, we should refuse to add a device to this bus instead of silently ignoring it. Looking at the QEMU sources, PS/2 is only available if the QEMU binary has the "i8042"

Re: [libvirt] [PATCH] qemu: Refuse to use "ps2" on machines that do not have this bus

2020-01-15 Thread Daniel Henrique Barboza
On 1/15/20 9:23 AM, Thomas Huth wrote: The "ps2" bus is only available on certain machines like x86. On machines like s390x, we should refuse to add a device to this bus instead of silently ignoring it. Looking at the QEMU sources, PS/2 is only available if the QEMU binary has the "i8042"

Re: [libvirt] [PATCH] qemu: Refuse to use "ps2" on machines that do not have this bus

2020-01-15 Thread Daniel Henrique Barboza
On 1/15/20 9:23 AM, Thomas Huth wrote: The "ps2" bus is only available on certain machines like x86. On machines like s390x, we should refuse to add a device to this bus instead of silently ignoring it. Looking at the QEMU sources, PS/2 is only available if the QEMU binary has the "i8042"

[libvirt] [PATCH] qemu: Refuse to use "ps2" on machines that do not have this bus

2020-01-15 Thread Thomas Huth
The "ps2" bus is only available on certain machines like x86. On machines like s390x, we should refuse to add a device to this bus instead of silently ignoring it. Looking at the QEMU sources, PS/2 is only available if the QEMU binary has the "i8042" device, so let's check for that and only allow