[libvirt] [PATCH] qemu: Resolve Coverity DEADCODE

2015-07-01 Thread John Ferlan
Commit id 'f967e7a6' didn't place the closing parentheses quite right causing DEADCODE errors since the rc setting/comparison was wrong. Signed-off-by: John Ferlan jfer...@redhat.com --- src/qemu/qemu_hotplug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [libvirt] [PATCH] qemu: Resolve Coverity DEADCODE

2015-07-01 Thread Ján Tomko
On Wed, Jul 01, 2015 at 06:31:07AM -0400, John Ferlan wrote: Commit id 'f967e7a6' didn't place the closing parentheses quite right causing DEADCODE errors since the rc setting/comparison was wrong. Signed-off-by: John Ferlan jfer...@redhat.com --- src/qemu/qemu_hotplug.c | 2 +- 1 file

[libvirt] [PATCH] qemu: Resolve Coverity DEADCODE

2015-04-27 Thread John Ferlan
Coverity notes taht the switch() used to check 'connected' values has two DEADCODE paths (_DEFAULT _LAST). Since 'connected' is a boolean it can only be one or the other (CONNECTED or DISCONNECTED), so it just seems pointless to use a switch to get all values. Convert to if-else Signed-off-by:

Re: [libvirt] [PATCH] qemu: Resolve Coverity DEADCODE

2015-04-27 Thread Michal Privoznik
On 27.04.2015 13:33, John Ferlan wrote: Coverity notes taht the switch() used to check 'connected' values has s/taht/that/ two DEADCODE paths (_DEFAULT _LAST). Since 'connected' is a boolean it can only be one or the other (CONNECTED or DISCONNECTED), so it just seems pointless to use a

Re: [libvirt] [PATCH] qemu: Resolve Coverity DEADCODE

2015-04-27 Thread John Ferlan
On 04/27/2015 07:51 AM, Michal Privoznik wrote: On 27.04.2015 13:33, John Ferlan wrote: Coverity notes taht the switch() used to check 'connected' values has s/taht/that/ two DEADCODE paths (_DEFAULT _LAST). Since 'connected' is a boolean it can only be one or the other (CONNECTED or

Re: [libvirt] [PATCH] qemu: Resolve Coverity DEADCODE

2015-04-27 Thread Peter Krempa
On Mon, Apr 27, 2015 at 07:33:06 -0400, John Ferlan wrote: Coverity notes taht the switch() used to check 'connected' values has two DEADCODE paths (_DEFAULT _LAST). Since 'connected' is a boolean it can only be one or the other (CONNECTED or DISCONNECTED), so it just seems pointless to use

Re: [libvirt] [PATCH] qemu: Resolve Coverity DEADCODE

2015-04-27 Thread Michal Privoznik
On 27.04.2015 14:22, John Ferlan wrote: On 04/27/2015 07:51 AM, Michal Privoznik wrote: On 27.04.2015 13:33, John Ferlan wrote: Coverity notes taht the switch() used to check 'connected' values has s/taht/that/ two DEADCODE paths (_DEFAULT _LAST). Since 'connected' is a boolean it

Re: [libvirt] [PATCH] qemu: Resolve Coverity DEADCODE

2015-04-27 Thread John Ferlan
On 04/27/2015 11:22 AM, Michal Privoznik wrote: On 27.04.2015 14:22, John Ferlan wrote: On 04/27/2015 07:51 AM, Michal Privoznik wrote: On 27.04.2015 13:33, John Ferlan wrote: Coverity notes taht the switch() used to check 'connected' values has s/taht/that/ two DEADCODE paths