Re: [libvirt] [PATCH] qemu: avoid double reservation of PCI address when hotplugging interface type='hostdev'

2019-10-23 Thread Andrea Bolognani
On Tue, 2019-10-22 at 14:25 -0400, Laine Stump wrote: > On 10/21/19 9:02 AM, Andrea Bolognani wrote: > > On Sat, 2019-10-19 at 02:18 -0400, Laine Stump wrote: > > > Commit 01ca4010d86 (libvirt v5.1.0) moved address reservation for > > > hotplugged interface devices up to an earlier point in > > >

Re: [libvirt] [PATCH] qemu: avoid double reservation of PCI address when hotplugging interface type='hostdev'

2019-10-22 Thread Laine Stump
On 10/21/19 9:02 AM, Andrea Bolognani wrote: On Sat, 2019-10-19 at 02:18 -0400, Laine Stump wrote: Commit 01ca4010d86 (libvirt v5.1.0) moved address reservation for hotplugged interface devices up to an earlier point in qemuDomainAttachNetDevice() because some function called when hotplugging

Re: [libvirt] [PATCH] qemu: avoid double reservation of PCI address when hotplugging interface type='hostdev'

2019-10-22 Thread Andrea Bolognani
On Sat, 2019-10-19 at 02:18 -0400, Laine Stump wrote: > Commit 01ca4010d86 (libvirt v5.1.0) moved address reservation for > hotplugged interface devices up to an earlier point in > qemuDomainAttachNetDevice() because some function called when > hotplugging on aarch64 needed to know the address

[libvirt] [PATCH] qemu: avoid double reservation of PCI address when hotplugging interface type='hostdev'

2019-10-19 Thread Laine Stump
Commit 01ca4010d86 (libvirt v5.1.0) moved address reservation for hotplugged interface devices up to an earlier point in qemuDomainAttachNetDevice() because some function called when hotplugging on aarch64 needed to know the address type, and failed when it was "none". This unfortunately caused a