Re: [libvirt] [PATCH] qemu: blockCopy: Allow shallow block copy into a raw image

2015-04-28 Thread Eric Blake
On 04/27/2015 10:08 PM, Shanzhi Yu wrote: Should libvirt post error when try a shallow blockcopy of file without backing file, just as shallow blockcommit? I cannot reproduce the error above, could you please post steps to do that? or perhaps debug log from libvirt? It is easy to reproduce.

[libvirt] [PATCH] qemu: blockCopy: Allow shallow block copy into a raw image

2015-04-27 Thread Peter Krempa
The documentation states that for shallow block copy the image has to have the same guest visible content as backing file of the current image. This condition can be achieved also with a raw file (or a qcow without a backing file) so remove the condition that would disallow it. (This patch

Re: [libvirt] [PATCH] qemu: blockCopy: Allow shallow block copy into a raw image

2015-04-27 Thread Shanzhi Yu
On 04/27/2015 08:01 PM, Peter Krempa wrote: The documentation states that for shallow block copy the image has to have the same guest visible content as backing file of the current image. This condition can be achieved also with a raw file (or a qcow without a backing file) so remove the

Re: [libvirt] [PATCH] qemu: blockCopy: Allow shallow block copy into a raw image

2015-04-27 Thread Shanzhi Yu
On 04/27/2015 11:38 PM, Peter Krempa wrote: On Mon, Apr 27, 2015 at 22:11:40 +0800, Shanzhi Yu wrote: On 04/27/2015 08:01 PM, Peter Krempa wrote: The documentation states that for shallow block copy the image has to have the same guest visible content as backing file of the current image.

Re: [libvirt] [PATCH] qemu: blockCopy: Allow shallow block copy into a raw image

2015-04-27 Thread Peter Krempa
On Mon, Apr 27, 2015 at 22:11:40 +0800, Shanzhi Yu wrote: On 04/27/2015 08:01 PM, Peter Krempa wrote: The documentation states that for shallow block copy the image has to have the same guest visible content as backing file of the current image. This condition can be achieved also with

Re: [libvirt] [PATCH] qemu: blockCopy: Allow shallow block copy into a raw image

2015-04-27 Thread Eric Blake
On 04/27/2015 06:01 AM, Peter Krempa wrote: The documentation states that for shallow block copy the image has to have the same guest visible content as backing file of the current image. This condition can be achieved also with a raw file (or a qcow without a backing file) so remove the