Re: [libvirt] [PATCH] qemu: caps: Use unique key for domCaps caching

2019-10-17 Thread Cole Robinson
On 10/16/19 12:22 PM, Jonathon Jongsma wrote: > On Wed, 2019-10-16 at 09:12 -0300, Daniel Henrique Barboza wrote: >> >> On 10/15/19 1:01 PM, Cole Robinson wrote: >>> When searching qemuCaps->domCapsCache for existing domCaps data, >>> we check for a matching pair of arch+virttype+machine+emulator.

Re: [libvirt] [PATCH] qemu: caps: Use unique key for domCaps caching

2019-10-16 Thread Jonathon Jongsma
On Wed, 2019-10-16 at 09:12 -0300, Daniel Henrique Barboza wrote: > > On 10/15/19 1:01 PM, Cole Robinson wrote: > > When searching qemuCaps->domCapsCache for existing domCaps data, > > we check for a matching pair of arch+virttype+machine+emulator. > > However > > for the hash table key we only us

Re: [libvirt] [PATCH] qemu: caps: Use unique key for domCaps caching

2019-10-16 Thread Daniel Henrique Barboza
On 10/15/19 1:01 PM, Cole Robinson wrote: When searching qemuCaps->domCapsCache for existing domCaps data, we check for a matching pair of arch+virttype+machine+emulator. However for the hash table key we only use the machine string. So if the cache already contains: x86_64 + kvm + pc + /u

[libvirt] [PATCH] qemu: caps: Use unique key for domCaps caching

2019-10-15 Thread Cole Robinson
When searching qemuCaps->domCapsCache for existing domCaps data, we check for a matching pair of arch+virttype+machine+emulator. However for the hash table key we only use the machine string. So if the cache already contains: x86_64 + kvm + pc + /usr/bin/qemu-kvm But a new VM is defined with