Re: [libvirt] [PATCH] qemu: endjob returns a bool

2013-09-10 Thread Eric Blake
On 09/09/2013 01:43 PM, Doug Goldstein wrote: On Mon, Sep 9, 2013 at 2:12 PM, Eric Blake ebl...@redhat.com wrote: Osier Yang pointed out that ever since commit 31cb030, the signature of qemuDomainObjEndJob was changed to return a bool. While comparison against 0 or 0 still gives the right

[libvirt] [PATCH] qemu: endjob returns a bool

2013-09-09 Thread Eric Blake
Osier Yang pointed out that ever since commit 31cb030, the signature of qemuDomainObjEndJob was changed to return a bool. While comparison against 0 or 0 still gives the right results, it looks fishy; we also had one place that was comparing 0 which is effectively dead code. *

Re: [libvirt] [PATCH] qemu: endjob returns a bool

2013-09-09 Thread Doug Goldstein
On Mon, Sep 9, 2013 at 2:12 PM, Eric Blake ebl...@redhat.com wrote: Osier Yang pointed out that ever since commit 31cb030, the signature of qemuDomainObjEndJob was changed to return a bool. While comparison against 0 or 0 still gives the right results, it looks fishy; we also had one place