Re: [libvirt] [PATCH] qemu: fix EFI nvram removal on domain undefine

2019-10-15 Thread Pavel Mores
On Tue, Oct 15, 2019 at 03:45:55PM +0200, Michal Privoznik wrote: > On 10/15/19 3:15 PM, Pavel Mores wrote: > > On Tue, Oct 15, 2019 at 01:51:32PM +0200, Michal Privoznik wrote: > > > On 10/15/19 10:31 AM, Pavel Mores wrote: > > > > When undefining a UEFI domain its nvram file has to be properly

Re: [libvirt] [PATCH] qemu: fix EFI nvram removal on domain undefine

2019-10-15 Thread Michal Privoznik
On 10/15/19 3:15 PM, Pavel Mores wrote: On Tue, Oct 15, 2019 at 01:51:32PM +0200, Michal Privoznik wrote: On 10/15/19 10:31 AM, Pavel Mores wrote: When undefining a UEFI domain its nvram file has to be properly handled as well. It's mandatory to use one of --nvram and --keep-nvram options

Re: [libvirt] [PATCH] qemu: fix EFI nvram removal on domain undefine

2019-10-15 Thread Pavel Mores
On Tue, Oct 15, 2019 at 01:51:32PM +0200, Michal Privoznik wrote: > On 10/15/19 10:31 AM, Pavel Mores wrote: > > When undefining a UEFI domain its nvram file has to be properly handled as > > well. It's mandatory to use one of --nvram and --keep-nvram options when > > 'virsh undefine ' is issued

Re: [libvirt] [PATCH] qemu: fix EFI nvram removal on domain undefine

2019-10-15 Thread Michal Privoznik
On 10/15/19 10:31 AM, Pavel Mores wrote: When undefining a UEFI domain its nvram file has to be properly handled as well. It's mandatory to use one of --nvram and --keep-nvram options when 'virsh undefine ' is issued for a UEFI domain. To fix the bug as reported, virsh should return an error

[libvirt] [PATCH] qemu: fix EFI nvram removal on domain undefine

2019-10-15 Thread Pavel Mores
When undefining a UEFI domain its nvram file has to be properly handled as well. It's mandatory to use one of --nvram and --keep-nvram options when 'virsh undefine ' is issued for a UEFI domain. To fix the bug as reported, virsh should return an error message if neither option is used and the