Re: [libvirt] [PATCH] qemu: fix sometimes error overwrite when we fail to start/migrate/restore

2015-03-19 Thread lhuang
On 03/19/2015 05:27 PM, Ján Tomko wrote: On Thu, Mar 19, 2015 at 11:14:39AM +0800, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1196934 Adding a comment in the bugzilla saying you posted a patch (with a link to libvir-list archives) can be helpful. Otherwise they might send

Re: [libvirt] [PATCH] qemu: fix sometimes error overwrite when we fail to start/migrate/restore

2015-03-19 Thread Ján Tomko
On Thu, Mar 19, 2015 at 11:14:39AM +0800, Luyao Huang wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1196934 Adding a comment in the bugzilla saying you posted a patch (with a link to libvir-list archives) can be helpful. Otherwise they might send the exact same patch - if your was not

[libvirt] [PATCH] qemu: fix sometimes error overwrite when we fail to start/migrate/restore

2015-03-18 Thread Luyao Huang
https://bugzilla.redhat.com/show_bug.cgi?id=1196934 When start/migrate/restore a vm failed, libvirt will try to catch the log in /var/log/libvirt/qemu/vm.log and output them before. However we add a check in qemuDomainObjExitMonitor after commit dc2fd51f, this will overwrite the error set in