Re: [libvirt] [PATCH] qemu: fix text block info parsing

2011-10-13 Thread Daniel Veillard
On Wed, Oct 12, 2011 at 06:30:08PM -0600, Eric Blake wrote: Detected by Coverity. p (the pointer to the string) is always true; when in reality, we wanted to know whether the integer value of the just-parsed string is '0' or '1'. Logic bug since commit b1b5b51. *

Re: [libvirt] [PATCH] qemu: fix text block info parsing

2011-10-13 Thread Eric Blake
On 10/13/2011 03:15 AM, Daniel Veillard wrote: On Wed, Oct 12, 2011 at 06:30:08PM -0600, Eric Blake wrote: Detected by Coverity. p (the pointer to the string) is always true; when in reality, we wanted to know whether the integer value of the just-parsed string is '0' or '1'. Logic bug since

[libvirt] [PATCH] qemu: fix text block info parsing

2011-10-12 Thread Eric Blake
Detected by Coverity. p (the pointer to the string) is always true; when in reality, we wanted to know whether the integer value of the just-parsed string is '0' or '1'. Logic bug since commit b1b5b51. * src/qemu/qemu_monitor_text.c (qemuMonitorTextGetBlockInfo): Set results to proper value.