Re: [libvirt] [PATCH] qemu: forbid large value wraparound in balloon period collection

2015-02-26 Thread Martin Kletzander
On Thu, Feb 26, 2015 at 05:42:10PM +0100, Erik Skultety wrote: On 02/25/2015 08:10 AM, Martin Kletzander wrote: On Tue, Feb 24, 2015 at 04:28:18PM +0100, Erik Skultety wrote: We do parse and represent period collection as unsigned int in our internal structures, however commit

Re: [libvirt] [PATCH] qemu: forbid large value wraparound in balloon period collection

2015-02-26 Thread Erik Skultety
On 02/25/2015 08:10 AM, Martin Kletzander wrote: On Tue, Feb 24, 2015 at 04:28:18PM +0100, Erik Skultety wrote: We do parse and represent period collection as unsigned int in our internal structures, however commit d5c67e7f4523450023b89b69c16472582c85eeaf converts this to int, thus wrapping

Re: [libvirt] [PATCH] qemu: forbid large value wraparound in balloon period collection

2015-02-25 Thread John Ferlan
On 02/25/2015 02:10 AM, Martin Kletzander wrote: On Tue, Feb 24, 2015 at 04:28:18PM +0100, Erik Skultety wrote: We do parse and represent period collection as unsigned int in our internal structures, however commit d5c67e7f4523450023b89b69c16472582c85eeaf converts this to int, thus wrapping

[libvirt] [PATCH] qemu: forbid large value wraparound in balloon period collection

2015-02-24 Thread Erik Skultety
We do parse and represent period collection as unsigned int in our internal structures, however commit d5c67e7f4523450023b89b69c16472582c85eeaf converts this to int, thus wrapping around inputs greater than INT_MAX which results in an error from QEMU. This patch adds a check into QEMU driver,

Re: [libvirt] [PATCH] qemu: forbid large value wraparound in balloon period collection

2015-02-24 Thread Martin Kletzander
On Tue, Feb 24, 2015 at 04:28:18PM +0100, Erik Skultety wrote: We do parse and represent period collection as unsigned int in our internal structures, however commit d5c67e7f4523450023b89b69c16472582c85eeaf converts this to int, thus wrapping around inputs greater than INT_MAX which results in