Re: [libvirt] [PATCH] qemu: make attaching disk partition to VM illegal

2019-09-30 Thread Pavel Mores
On Mon, Sep 30, 2019 at 08:38:20AM +0200, Peter Krempa wrote: > On Fri, Sep 27, 2019 at 12:41:29 -0300, Daniel Henrique Barboza wrote: > > > > > > > +virReportError(VIR_ERR_CONFIG_UNSUPPORTED, > > > + _("can't attach disk partition '%s', please > > > attach whole di

Re: [libvirt] [PATCH] qemu: make attaching disk partition to VM illegal

2019-09-29 Thread Peter Krempa
On Fri, Sep 27, 2019 at 12:41:29 -0300, Daniel Henrique Barboza wrote: > > > On 9/27/19 12:11 PM, Pavel Mores wrote: > > The way in which the qemu driver generates aliases for disks involves > > ignoring the partition number part of a target dev name. This means that > > all partitions of a bloc

Re: [libvirt] [PATCH] qemu: make attaching disk partition to VM illegal

2019-09-27 Thread Daniel Henrique Barboza
On 9/27/19 12:11 PM, Pavel Mores wrote: The way in which the qemu driver generates aliases for disks involves ignoring the partition number part of a target dev name. This means that all partitions of a block device and the device itself all end up with the same alias. If multiple such disks

[libvirt] [PATCH] qemu: make attaching disk partition to VM illegal

2019-09-27 Thread Pavel Mores
The way in which the qemu driver generates aliases for disks involves ignoring the partition number part of a target dev name. This means that all partitions of a block device and the device itself all end up with the same alias. If multiple such disks are specified in XML, the resulting name cla