Re: [libvirt] [PATCH] qemuBuildMemoryBackendStr: Handle one more corner case

2017-08-10 Thread Martin Kletzander
On Thu, Aug 10, 2017 at 05:43:13PM +0200, Michal Privoznik wrote: On 08/10/2017 03:44 PM, Martin Kletzander wrote: On Tue, Aug 08, 2017 at 05:04:15PM +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1458638 This code is so complicated because we allow enabling the

Re: [libvirt] [PATCH] qemuBuildMemoryBackendStr: Handle one more corner case

2017-08-10 Thread Michal Privoznik
On 08/10/2017 03:44 PM, Martin Kletzander wrote: > On Tue, Aug 08, 2017 at 05:04:15PM +0200, Michal Privoznik wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1458638 >> >> This code is so complicated because we allow enabling the same >> bits at many places. Just like in this case: huge

Re: [libvirt] [PATCH] qemuBuildMemoryBackendStr: Handle one more corner case

2017-08-10 Thread Martin Kletzander
On Tue, Aug 08, 2017 at 05:04:15PM +0200, Michal Privoznik wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1458638 This code is so complicated because we allow enabling the same bits at many places. Just like in this case: huge pages can be enabled by global element under or on per basis.

[libvirt] [PATCH] qemuBuildMemoryBackendStr: Handle one more corner case

2017-08-08 Thread Michal Privoznik
https://bugzilla.redhat.com/show_bug.cgi?id=1458638 This code is so complicated because we allow enabling the same bits at many places. Just like in this case: huge pages can be enabled by global element under or on per basis. To complicate things a bit more, users are allowed to not specify