Re: [libvirt] [PATCH] qemuProcessInit: Jump onto correct label in case of error

2017-02-24 Thread Marc Hartmayer
On Thu, Feb 23, 2017 at 05:46 PM +0100, Michal Privoznik wrote: > On 02/23/2017 05:40 PM, Marc Hartmayer wrote: >> On Thu, Feb 23, 2017 at 05:15 PM +0100, Michal Privoznik >> wrote: >>> After eca76884ea in case of error in qemuDomainSetPrivatePaths()

Re: [libvirt] [PATCH] qemuProcessInit: Jump onto correct label in case of error

2017-02-24 Thread Ján Tomko
On Thu, Feb 23, 2017 at 05:15:47PM +0100, Michal Privoznik wrote: After eca76884ea in case of error in qemuDomainSetPrivatePaths() in pretended start we jump to stop. I've changed this during review from 'cleanup' which turned out to be correct. Well, sort of. We can't call qemuProcessStop() as

Re: [libvirt] [PATCH] qemuProcessInit: Jump onto correct label in case of error

2017-02-23 Thread Michal Privoznik
On 02/23/2017 05:40 PM, Marc Hartmayer wrote: > On Thu, Feb 23, 2017 at 05:15 PM +0100, Michal Privoznik > wrote: >> After eca76884ea in case of error in qemuDomainSetPrivatePaths() >> in pretended start we jump to stop. I've changed this during >> review from 'cleanup'

Re: [libvirt] [PATCH] qemuProcessInit: Jump onto correct label in case of error

2017-02-23 Thread Marc Hartmayer
On Thu, Feb 23, 2017 at 05:15 PM +0100, Michal Privoznik wrote: > After eca76884ea in case of error in qemuDomainSetPrivatePaths() > in pretended start we jump to stop. I've changed this during > review from 'cleanup' which turned out to be correct. Well, sort > of. We can't

[libvirt] [PATCH] qemuProcessInit: Jump onto correct label in case of error

2017-02-23 Thread Michal Privoznik
After eca76884ea in case of error in qemuDomainSetPrivatePaths() in pretended start we jump to stop. I've changed this during review from 'cleanup' which turned out to be correct. Well, sort of. We can't call qemuProcessStop() as it decrements driver->nactive and we did not increment it. However,