Re: [libvirt] [PATCH] qemudOpenMonitor: fix open(2) error check

2008-07-25 Thread Daniel P. Berrange
On Thu, Jul 24, 2008 at 03:48:47PM -0400, Guido G?nther wrote: Hi, open returns -1 on failure. Pointed out by Guido Trotter on: Opps, very embarrassing bug :-) ACK Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o-

Re: [libvirt] [PATCH] qemudOpenMonitor: fix open(2) error check

2008-07-25 Thread Daniel Veillard
On Thu, Jul 24, 2008 at 03:48:47PM -0400, Guido Günther wrote: Hi, open returns -1 on failure. Pointed out by Guido Trotter on: http://bugs.debian.org/492250 Patch against current CVS attached. Hum, good catch, I checked for other occurences of this mistake but everywhere else we use 0

[libvirt] [PATCH] qemudOpenMonitor: fix open(2) error check

2008-07-24 Thread Guido Günther
Hi, open returns -1 on failure. Pointed out by Guido Trotter on: http://bugs.debian.org/492250 Patch against current CVS attached. -- Guido --- src/qemu_driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index