Re: [libvirt] [PATCH] rbd: Do not append Ceph monitor port number 6789 if not provided

2016-01-06 Thread Andrea Bolognani
On Wed, 2016-01-06 at 10:27 +0100, Wido den Hollander wrote: >  > On 01/06/2016 09:49 AM, Andrea Bolognani wrote: > > On Wed, 2016-01-06 at 09:32 +0100, Wido den Hollander wrote: > > > diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c > > > index 2aa1d90..1354601 100644 > > > ---

Re: [libvirt] [PATCH] rbd: Do not append Ceph monitor port number 6789 if not provided

2016-01-06 Thread Andrea Bolognani
On Wed, 2016-01-06 at 09:32 +0100, Wido den Hollander wrote: > diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c > index 2aa1d90..1354601 100644 > --- a/src/util/virstoragefile.c > +++ b/src/util/virstoragefile.c > @@ -2246,7 +2246,7 @@

Re: [libvirt] [PATCH] rbd: Do not append Ceph monitor port number 6789 if not provided

2016-01-06 Thread Wido den Hollander
On 01/06/2016 09:49 AM, Andrea Bolognani wrote: > On Wed, 2016-01-06 at 09:32 +0100, Wido den Hollander wrote: >> diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c >> index 2aa1d90..1354601 100644 >> --- a/src/util/virstoragefile.c >> +++ b/src/util/virstoragefile.c >> @@

[libvirt] [PATCH] rbd: Do not append Ceph monitor port number 6789 if not provided

2016-01-06 Thread Wido den Hollander
If no port number was provided for a storage pool libvirt defaults to port 6789; however, librbd/librados already default to 6789 when no port number is provided. In the future Ceph will switch to a new port for the Ceph monitors since port 6789 is already assigned to a different application by

[libvirt] [PATCH] rbd: Do not append Ceph monitor port number 6789 if not provided

2016-01-06 Thread Wido den Hollander
If no port number was provided for a storage pool libvirt defaults to port 6789; however, librbd/librados already default to 6789 when no port number is provided. In the future Ceph will switch to a new port for the Ceph monitors since port 6789 is already assigned to a different application by

Re: [libvirt] [PATCH] rbd: Do not append Ceph monitor port number 6789 if not provided

2016-01-06 Thread John Ferlan
On 01/06/2016 05:36 AM, Wido den Hollander wrote: > If no port number was provided for a storage pool libvirt defaults to > port 6789; however, librbd/librados already default to 6789 when no port > number is provided. > > In the future Ceph will switch to a new port for the Ceph monitors since

Re: [libvirt] [PATCH] rbd: Do not append Ceph monitor port number 6789 if not provided

2016-01-06 Thread Wido den Hollander
On 06-01-16 14:55, John Ferlan wrote: > > > On 01/06/2016 05:36 AM, Wido den Hollander wrote: >> If no port number was provided for a storage pool libvirt defaults to >> port 6789; however, librbd/librados already default to 6789 when no port >> number is provided. >> >> In the future Ceph

Re: [libvirt] [PATCH] rbd: Do not append Ceph monitor port number 6789 if not provided

2016-01-05 Thread Wido den Hollander
On 01/05/2016 11:36 PM, John Ferlan wrote: > > > On 12/28/2015 10:33 AM, Wido den Hollander wrote: >> If no port number was provided for a storage pool libvirt would default >> to port 6789. >> >> librbd/librados will however already default to 6789 when no port number >> is provided. > >

Re: [libvirt] [PATCH] rbd: Do not append Ceph monitor port number 6789 if not provided

2016-01-05 Thread John Ferlan
On 12/28/2015 10:33 AM, Wido den Hollander wrote: > If no port number was provided for a storage pool libvirt would default > to port 6789. > > librbd/librados will however already default to 6789 when no port number > is provided. reads better as: If no port number was provided for a storage

[libvirt] [PATCH] rbd: Do not append Ceph monitor port number 6789 if not provided

2015-12-28 Thread Wido den Hollander
If no port number was provided for a storage pool libvirt would default to port 6789. librbd/librados will however already default to 6789 when no port number is provided. In the future Ceph will however switch to a new port for the Ceph monitors since port 6789 is already assigned to a