Re: [libvirt] [PATCH] rpc: avoid libvirtd crash on unexpected client close

2011-08-02 Thread Daniel P. Berrange
On Mon, Aug 01, 2011 at 01:53:19PM -0600, Eric Blake wrote: Steps to reproduce this problem (vm1 is not running): for i in `seq 50`; do virsh managedsave vm1 done; killall virsh Pre-patch, virNetServerClientClose could end up setting client-sock to NULL prior to other cleanup functions

Re: [libvirt] [PATCH] rpc: avoid libvirtd crash on unexpected client close

2011-08-02 Thread Eric Blake
On 08/02/2011 04:41 AM, Daniel P. Berrange wrote: On Mon, Aug 01, 2011 at 01:53:19PM -0600, Eric Blake wrote: Steps to reproduce this problem (vm1 is not running): for i in `seq 50`; do virsh managedsave vm1 done; killall virsh Pre-patch, virNetServerClientClose could end up setting

[libvirt] [PATCH] rpc: avoid libvirtd crash on unexpected client close

2011-08-01 Thread Eric Blake
Steps to reproduce this problem (vm1 is not running): for i in `seq 50`; do virsh managedsave vm1 done; killall virsh Pre-patch, virNetServerClientClose could end up setting client-sock to NULL prior to other cleanup functions trying to use client-sock. This fixes things by checking for NULL in

Re: [libvirt] [PATCH] rpc: avoid libvirtd crash on unexpected client close

2011-08-01 Thread Wen Congyang
At 08/02/2011 03:53 AM, Eric Blake Write: Steps to reproduce this problem (vm1 is not running): for i in `seq 50`; do virsh managedsave vm1 done; killall virsh Pre-patch, virNetServerClientClose could end up setting client-sock to NULL prior to other cleanup functions trying to use