Re: [libvirt] [PATCH] rpc: libssh: don't crash when known_hosts file path is not provided

2017-01-10 Thread Peter Krempa
On Tue, Jan 10, 2017 at 16:08:03 +0100, Pino Toscano wrote: > On Monday, 9 January 2017 15:16:46 CET Peter Krempa wrote: > > When connecting as root, the "hostsfile" variable would be NULL due to > > the code leading to this point. This would result into a crash when > > attempting to set the

Re: [libvirt] [PATCH] rpc: libssh: don't crash when known_hosts file path is not provided

2017-01-10 Thread Pino Toscano
On Monday, 9 January 2017 15:16:46 CET Peter Krempa wrote: > When connecting as root, the "hostsfile" variable would be NULL due to > the code leading to this point. This would result into a crash when > attempting to set the known hosts file path. Almost: the issue happens generally when

[libvirt] [PATCH] rpc: libssh: don't crash when known_hosts file path is not provided

2017-01-09 Thread Peter Krempa
When connecting as root, the "hostsfile" variable would be NULL due to the code leading to this point. This would result into a crash when attempting to set the known hosts file path. To avoid deviating from the approach taken in the libssh2 driver set the file to /dev/null so that all entries