Re: [libvirt] [PATCH] storage: Clean up error path for create buildPool failure

2016-01-05 Thread Ján Tomko
On Fri, Dec 18, 2015 at 08:07:36AM -0500, John Ferlan wrote: > Commit id 'aeb1078ab' added a buildPool option and failure path which > calls virStoragePoolObjRemove, which unlocks the pool, clears the 'pool' > variable, and goto cleanup. However, at cleanup virStoragePoolObjUnlock > is called

Re: [libvirt] [PATCH] storage: Clean up error path for create buildPool failure

2016-01-05 Thread John Ferlan
ping - Tks - John On 12/18/2015 08:07 AM, John Ferlan wrote: > Commit id 'aeb1078ab' added a buildPool option and failure path which > calls virStoragePoolObjRemove, which unlocks the pool, clears the 'pool' > variable, and goto cleanup. However, at cleanup virStoragePoolObjUnlock > is called

[libvirt] [PATCH] storage: Clean up error path for create buildPool failure

2015-12-18 Thread John Ferlan
Commit id 'aeb1078ab' added a buildPool option and failure path which calls virStoragePoolObjRemove, which unlocks the pool, clears the 'pool' variable, and goto cleanup. However, at cleanup virStoragePoolObjUnlock is called without check if pool is non NULL. Signed-off-by: John Ferlan