Re: [libvirt] [PATCH] storage: Fix bug of fs pool destroying

2012-11-21 Thread Peter Krempa
On 11/21/12 04:22, Osier Yang wrote: Regression introduced by commit 258e06c85b7, ret could be set to 1 or 0 by virStorageBackendFileSystemIsMounted before goto cleanup. This could mislead the callers (up to the public API virStoragePoolDestroy) to return success even the underlying umount

Re: [libvirt] [PATCH] storage: Fix bug of fs pool destroying

2012-11-21 Thread Osier Yang
On 2012年11月21日 21:20, Peter Krempa wrote: On 11/21/12 04:22, Osier Yang wrote: Regression introduced by commit 258e06c85b7, ret could be set to 1 or 0 by virStorageBackendFileSystemIsMounted before goto cleanup. This could mislead the callers (up to the public API virStoragePoolDestroy) to

[libvirt] [PATCH] storage: Fix bug of fs pool destroying

2012-11-20 Thread Osier Yang
Regression introduced by commit 258e06c85b7, ret could be set to 1 or 0 by virStorageBackendFileSystemIsMounted before goto cleanup. This could mislead the callers (up to the public API virStoragePoolDestroy) to return success even the underlying umount command fails. ---