[libvirt] [PATCH] storage: Fix memory leak in error path

2013-03-06 Thread Jiri Denemark
This also renames cleanup label as error since it is only used for error path rather then being common for both success and error paths. --- src/storage/storage_backend_logical.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git

Re: [libvirt] [PATCH] storage: Fix memory leak in error path

2013-03-06 Thread John Ferlan
On 03/06/2013 06:59 AM, Jiri Denemark wrote: This also renames cleanup label as error since it is only used for error path rather then being common for both success and error paths. --- src/storage/storage_backend_logical.c | 15 --- 1 file changed, 8 insertions(+), 7

Re: [libvirt] [PATCH] storage: Fix memory leak in error path

2013-03-06 Thread Peter Krempa
On 03/06/13 12:59, Jiri Denemark wrote: This also renames cleanup label as error since it is only used for error path rather then being common for both success and error paths. --- src/storage/storage_backend_logical.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-)

Re: [libvirt] [PATCH] storage: Fix memory leak in error path

2013-03-06 Thread John Ferlan
On 03/06/2013 07:35 AM, John Ferlan wrote: On 03/06/2013 06:59 AM, Jiri Denemark wrote: +virFreeError(err); Not that it matters here, but I did find at least one path where a virSaveLastError() didn't call virFreeError() (e.g in storage_backend_logical.c). Oy - wrong window - gotta

Re: [libvirt] [PATCH] storage: Fix memory leak in error path

2013-03-06 Thread Jiri Denemark
On Wed, Mar 06, 2013 at 07:35:15 -0500, John Ferlan wrote: On 03/06/2013 06:59 AM, Jiri Denemark wrote: This also renames cleanup label as error since it is only used for error path rather then being common for both success and error paths. --- src/storage/storage_backend_logical.c | 15