Re: [libvirt] [PATCH] storage: add RBD support to disk source pool translation

2015-07-01 Thread Thibault VINCENT
On 06/25/2015 09:16 PM, John Ferlan wrote: > My assumption without doing too much thinking is that at some point the > virStorageBackendRBDRefreshPool will reconnect for you in the > storageDriverAutostart path... > > While not exactly the same, consider how the iSCSI pool handles uses the > check

Re: [libvirt] [PATCH] storage: add RBD support to disk source pool translation

2015-06-25 Thread John Ferlan
On 06/25/2015 06:21 AM, Thibault VINCENT wrote: > On 09/06/2015 17:33, John Ferlan wrote: >> I still think I need a tweak on what I posted as an update - the >> libvirtd restart path is always a bit tricky. The 'pooltype' isn't >> filled in at XML processing time and virStorageTranslateDiskSource

Re: [libvirt] [PATCH] storage: add RBD support to disk source pool translation

2015-06-25 Thread Thibault VINCENT
On 09/06/2015 17:33, John Ferlan wrote: I still think I need a tweak on what I posted as an update - the libvirtd restart path is always a bit tricky. The 'pooltype' isn't filled in at XML processing time and virStorageTranslateDiskSourcePool is only called after XML processing (sigh), so relying

Re: [libvirt] [PATCH] storage: add RBD support to disk source pool translation

2015-06-09 Thread John Ferlan
On 06/09/2015 10:47 AM, Thibault VINCENT wrote: > On 09/06/2015 14:45, John Ferlan wrote: >> Your cover letter indicates you didn't find any bit of documentation, >> but I'll point out that the formatdomain.html.in describes the "> type='volume'.../>" and how the "> use a disk type volume.. > >

Re: [libvirt] [PATCH] storage: add RBD support to disk source pool translation

2015-06-09 Thread Thibault VINCENT
On 09/06/2015 14:45, John Ferlan wrote: Your cover letter indicates you didn't find any bit of documentation, but I'll point out that the formatdomain.html.in describes the "" and how the " It's a misunderstanding, I never wished to imply a lack of information existed on how to use the feature.

Re: [libvirt] [PATCH] storage: add RBD support to disk source pool translation

2015-06-09 Thread John Ferlan
On 06/02/2015 09:56 AM, Thibault VINCENT wrote: > Domains can now reference disks of type 'volume' with an underlying RBD pool. > It won't allow mapping snapshots, pools don't list them yet, only COW clones. > > - virStorageTranslateDiskSourcePool: add case to copy RBD attributes > - virStorag

Re: [libvirt] [PATCH] storage: add RBD support to disk source pool translation

2015-06-09 Thread Thibault VINCENT
On 09/06/2015 01:12, Thibault VINCENT wrote: Any idea about this one? Not sure if it's bad or getting lost in backlog, and I'd like to see it in next release. Actually I'm going to submit a new version, please don't merge. Latest patch from John Ferlan about secrettype for iSCSI revealed the s

Re: [libvirt] [PATCH] storage: add RBD support to disk source pool translation

2015-06-08 Thread Thibault VINCENT
Hello, Any idea about this one? Not sure if it's bad or getting lost in backlog, and I'd like to see it in next release. Cheers -- Thibault -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

[libvirt] [PATCH] storage: add RBD support to disk source pool translation

2015-06-02 Thread Thibault VINCENT
Domains can now reference disks of type 'volume' with an underlying RBD pool. It won't allow mapping snapshots, pools don't list them yet, only COW clones. - virStorageTranslateDiskSourcePool: add case to copy RBD attributes - virStorageAddRBDPoolSourceHost: new helper to copy monitor hosts ---

[libvirt] [PATCH] storage: add RBD support to disk source pool translation

2015-06-02 Thread Thibault VINCENT
Hello, We needed this to avoid redundancies when defining domains with RBD backends, because monitor list and authentication secret could not be pulled from the storage pool. I didn't find any bit of documentation to update, actually it already implies that disks with source type 'volume' would w