On Fri, May 12, 2017 at 12:36 AM, John Ferlan wrote:
> Also your commit message notes "world readable", but by going from 755
> to 711, you're also changing to "group readable" too ;-)
>
Good catch John,
the other feedback seems good, so for now I'm just rewording in regard to
this and resubmit
On Mon, May 15, 2017 at 10:27 AM, Daniel P. Berrange
wrote:
> > Kinda surprised this didn't generate some immediate discussion... I
> > would also think that if you had a desire to change defaults you'd also
> > have a libvirt.spec.in adjustment...
>
> Actually no it doesn't - the spec file is a
On Mon, May 15, 2017 at 09:27:38AM +0100, Daniel P. Berrange wrote:
On Thu, May 11, 2017 at 06:36:22PM -0400, John Ferlan wrote:
On 05/11/2017 04:31 AM, Christian Ehrhardt wrote:
> From: Serge Hallyn
>
> There should be no need to make dir based pools world readable.
> So use 0711, not 0755,
On Thu, May 11, 2017 at 06:36:22PM -0400, John Ferlan wrote:
>
>
> On 05/11/2017 04:31 AM, Christian Ehrhardt wrote:
> > From: Serge Hallyn
> >
> > There should be no need to make dir based pools world readable.
> > So use 0711, not 0755, as the default perms for storage dirs.
> >
> > Signed-o
On 05/11/2017 04:31 AM, Christian Ehrhardt wrote:
> From: Serge Hallyn
>
> There should be no need to make dir based pools world readable.
> So use 0711, not 0755, as the default perms for storage dirs.
>
> Signed-off-by: Christian Ehrhardt
> ---
> docs/formatstorage.html.in | 2 +-
> src/st
From: Serge Hallyn
There should be no need to make dir based pools world readable.
So use 0711, not 0755, as the default perms for storage dirs.
Signed-off-by: Christian Ehrhardt
---
docs/formatstorage.html.in | 2 +-
src/storage/storage_util.h | 2 +-
2 files changed, 2 insertions(+), 2 delet
