Re: [libvirt] [PATCH] storage_util: Prefer generic FICLONE over btrfs/xfs defines

2018-07-10 Thread Andrea Bolognani
On Mon, 2018-07-09 at 16:59 +0200, Michal Privoznik wrote: > After my change to the original patch that resulted in commit > 8ed874b39b3 it was brought to my attention that all three defines > are the same: FICLONE = BTRFS_IOC_CLONE = XFS_IOC_CLONE. I'd mention that this is documented in ioctl_fic

[libvirt] [PATCH] storage_util: Prefer generic FICLONE over btrfs/xfs defines

2018-07-09 Thread Michal Privoznik
After my change to the original patch that resulted in commit 8ed874b39b3 it was brought to my attention that all three defines are the same: FICLONE = BTRFS_IOC_CLONE = XFS_IOC_CLONE. Therefore we should prefer generic FICLONE over 'specific' defines for btrfs/xfs. Signed-off-by: Michal Privoznik