Re: [libvirt] [PATCH] test_driver: implement virDomainInterfaceAddresses

2019-06-17 Thread Ilias Stamatis
On Mon, Jun 17, 2019 at 11:12 AM Michal Privoznik wrote: > > On 5/22/19 10:10 PM, Ilias Stamatis wrote: > > Ignore @source in the case of the test driver and return fixed private > > IPv4 addresses for all the interfaces defined in the domain. > > > > Signed-off-by: Ilias Stamatis > > --- > > > >

Re: [libvirt] [PATCH] test_driver: implement virDomainInterfaceAddresses

2019-06-17 Thread Michal Privoznik
On 5/22/19 10:10 PM, Ilias Stamatis wrote: Ignore @source in the case of the test driver and return fixed private IPv4 addresses for all the interfaces defined in the domain. Signed-off-by: Ilias Stamatis --- The default config of the test driver has no guest interfaces defined, so this must b

Re: [libvirt] [PATCH] test_driver: implement virDomainInterfaceAddresses

2019-05-23 Thread Erik Skultety
On Thu, May 23, 2019 at 11:36:31AM +0200, Ilias Stamatis wrote: > On Thu, May 23, 2019 at 9:46 AM Erik Skultety wrote: > > > > On Wed, May 22, 2019 at 10:10:34PM +0200, Ilias Stamatis wrote: > > > Ignore @source in the case of the test driver and return fixed private > > > IPv4 addresses for all t

Re: [libvirt] [PATCH] test_driver: implement virDomainInterfaceAddresses

2019-05-23 Thread Ilias Stamatis
On Thu, May 23, 2019 at 9:46 AM Erik Skultety wrote: > > On Wed, May 22, 2019 at 10:10:34PM +0200, Ilias Stamatis wrote: > > Ignore @source in the case of the test driver and return fixed private > > IPv4 addresses for all the interfaces defined in the domain. > > > > Signed-off-by: Ilias Stamatis

Re: [libvirt] [PATCH] test_driver: implement virDomainInterfaceAddresses

2019-05-23 Thread Erik Skultety
On Wed, May 22, 2019 at 10:10:34PM +0200, Ilias Stamatis wrote: > Ignore @source in the case of the test driver and return fixed private > IPv4 addresses for all the interfaces defined in the domain. > > Signed-off-by: Ilias Stamatis > --- > > The default config of the test driver has no guest int

[libvirt] [PATCH] test_driver: implement virDomainInterfaceAddresses

2019-05-22 Thread Ilias Stamatis
Ignore @source in the case of the test driver and return fixed private IPv4 addresses for all the interfaces defined in the domain. Signed-off-by: Ilias Stamatis --- The default config of the test driver has no guest interfaces defined, so this must be tested with a custom config. Maybe it woul