Re: [libvirt] [PATCH] util: Avoid libvirtd crash

2012-04-30 Thread Eric Blake
The subject line is pretty generic; it's better to add something like the name of the function being fixed to minimize the chance of patch name collision causing backporters minor confusion in deciding what to backport. On 04/28/2012 05:01 AM, Alex Jia wrote: In fact, the 'tapfd' is always NULL,

[libvirt] [PATCH] util: Avoid libvirtd crash

2012-04-28 Thread Alex Jia
In fact, the 'tapfd' is always NULL, the function 'virNetDevTapCreate()' hasn't assign 'fd' to 'tapfd', when the function 'virNetDevSetMAC()' is failed then goto 'error' lable, finally, the VIR_FORCE_CLOSE() will deref a NULL 'tapfd'. * util/virnetdevtap.c (virNetDevTapCreateInBridgePort): fix a

Re: [libvirt] [PATCH] util: Avoid libvirtd crash

2012-04-28 Thread Stefan Berger
On 04/28/2012 07:01 AM, Alex Jia wrote: In fact, the 'tapfd' is always NULL, the function 'virNetDevTapCreate()' hasn't assign 'fd' to 'tapfd', when the function 'virNetDevSetMAC()' is failed then goto 'error' lable, finally, the VIR_FORCE_CLOSE() will deref a NULL 'tapfd'. ---