Re: [libvirt] [PATCH] util: clang is failing due to unused variables.

2018-07-27 Thread Julio Faracco
Ow, I was pretty sure that clang would complain about not handling the function return properly. Well, I changed it and clang is not throwing any error. Weird! Sending a V2. Michael's patch was applied, so we need a new one to remove the other occurrences. Em sex, 27 de jul de 2018 às 17:59,

Re: [libvirt] [PATCH] util: clang is failing due to unused variables.

2018-07-27 Thread Eric Blake
On 07/27/2018 03:58 PM, John Ferlan wrote: On 07/27/2018 04:50 PM, Julio Faracco wrote: After some recent patches, clang is throwing some errors related to unused variables. This is not happening when we use GCC with -Werror enabled. Only clang reports this warning. make[3]: Entering

Re: [libvirt] [PATCH] util: clang is failing due to unused variables.

2018-07-27 Thread John Ferlan
On 07/27/2018 04:50 PM, Julio Faracco wrote: > After some recent patches, clang is throwing some errors related to > unused variables. This is not happening when we use GCC with -Werror > enabled. Only clang reports this warning. > > make[3]: Entering directory

[libvirt] [PATCH] util: clang is failing due to unused variables.

2018-07-27 Thread Julio Faracco
After some recent patches, clang is throwing some errors related to unused variables. This is not happening when we use GCC with -Werror enabled. Only clang reports this warning. make[3]: Entering directory '/home/julio/Desktop/virt/libvirt/src' CC util/libvirt_util_la-virscsivhost.lo