Re: [libvirt] [PATCH] v2:Support for adding a static route to a bridge

2013-04-10 Thread Gene Czarcinski
On 04/09/2013 04:28 PM, Gene Czarcinski wrote: OK, how about having it both ways. If we can have both mask and prefix, why not both via and gateway. I know gateway has some history attached to it but the new /sbin/ip uses via. I am just trying to keep a line of text being as close to not

Re: [libvirt] [PATCH] v2:Support for adding a static route to a bridge

2013-04-10 Thread Laine Stump
On 04/09/2013 04:28 PM, Gene Czarcinski wrote: On 04/04/2013 12:08 PM, Laine Stump wrote: Except that it's obvious from your response that I misunderstood your patch, and thought that you were trying to make the route to an otherwise unreachable network a part of the unreachable network's

Re: [libvirt] [PATCH] v2:Support for adding a static route to a bridge

2013-04-10 Thread Laine Stump
On 04/10/2013 01:38 PM, Gene Czarcinski wrote: On 04/09/2013 04:28 PM, Gene Czarcinski wrote: OK, how about having it both ways. If we can have both mask and prefix, why not both via and gateway. I know gateway has some history attached to it but the new /sbin/ip uses via. I am just trying

Re: [libvirt] [PATCH] v2:Support for adding a static route to a bridge

2013-04-10 Thread Gene Czarcinski
On 04/10/2013 03:09 PM, Laine Stump wrote: On 04/09/2013 04:28 PM, Gene Czarcinski wrote: On 04/04/2013 12:08 PM, Laine Stump wrote: Except that it's obvious from your response that I misunderstood your patch, and thought that you were trying to make the route to an otherwise unreachable

Re: [libvirt] [PATCH] v2:Support for adding a static route to a bridge

2013-04-09 Thread Gene Czarcinski
On 04/04/2013 12:08 PM, Laine Stump wrote: On 04/03/2013 04:02 PM, Gene Czarcinski wrote: On 04/02/2013 03:31 PM, Laine Stump wrote: On 03/15/2013 02:10 PM, Gene Czarcinski wrote: This patch adds support for adding a static route for a network. The via specifies the gateway's IP address.

Re: [libvirt] [PATCH] v2:Support for adding a static route to a bridge

2013-04-04 Thread Laine Stump
On 04/03/2013 04:02 PM, Gene Czarcinski wrote: On 04/02/2013 03:31 PM, Laine Stump wrote: On 03/15/2013 02:10 PM, Gene Czarcinski wrote: This patch adds support for adding a static route for a network. The via specifies the gateway's IP address. Both IPv4 and IPv6 static routes are

Re: [libvirt] [PATCH] v2:Support for adding a static route to a bridge

2013-04-04 Thread Laine Stump
On 03/15/2013 02:10 PM, Gene Czarcinski wrote: diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 296871c..c90b3d2 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -729,6 +729,7 @@ int virNetDevGetVLanID(const char *ifname ATTRIBUTE_UNUSED, * Add an IP address

Re: [libvirt] [PATCH] v2:Support for adding a static route to a bridge

2013-04-03 Thread Gene Czarcinski
On 04/02/2013 03:31 PM, Laine Stump wrote: On 03/15/2013 02:10 PM, Gene Czarcinski wrote: This patch adds support for adding a static route for a network. The via specifies the gateway's IP address. Both IPv4 and IPv6 static routes are supported although it is expected that this functionality

Re: [libvirt] [PATCH] v2:Support for adding a static route to a bridge

2013-04-02 Thread Gene Czarcinski
On 03/20/2013 11:17 AM, Laine Stump wrote: On 03/20/2013 10:57 AM, Gene Czarcinski wrote: On 03/16/2013 09:32 AM, Gene Czarcinski wrote: On 03/15/2013 03:48 PM, Gene Czarcinski wrote: On 03/15/2013 02:10 PM, Gene Czarcinski wrote: This patch adds support for adding a static route for a

Re: [libvirt] [PATCH] v2:Support for adding a static route to a bridge

2013-04-02 Thread Laine Stump
On 03/15/2013 02:10 PM, Gene Czarcinski wrote: This patch adds support for adding a static route for a network. The via specifies the gateway's IP address. Both IPv4 and IPv6 static routes are supported although it is expected that this functionality will have more use with IPv6. (First I

Re: [libvirt] [PATCH] v2:Support for adding a static route to a bridge

2013-03-20 Thread Gene Czarcinski
On 03/16/2013 09:32 AM, Gene Czarcinski wrote: On 03/15/2013 03:48 PM, Gene Czarcinski wrote: On 03/15/2013 02:10 PM, Gene Czarcinski wrote: This patch adds support for adding a static route for a network. The via specifies the gateway's IP address. Both IPv4 and IPv6 static routes are

Re: [libvirt] [PATCH] v2:Support for adding a static route to a bridge

2013-03-20 Thread Laine Stump
On 03/20/2013 10:57 AM, Gene Czarcinski wrote: On 03/16/2013 09:32 AM, Gene Czarcinski wrote: On 03/15/2013 03:48 PM, Gene Czarcinski wrote: On 03/15/2013 02:10 PM, Gene Czarcinski wrote: This patch adds support for adding a static route for a network. The via specifies the gateway's IP

Re: [libvirt] [PATCH] v2:Support for adding a static route to a bridge

2013-03-16 Thread Gene Czarcinski
On 03/15/2013 03:48 PM, Gene Czarcinski wrote: On 03/15/2013 02:10 PM, Gene Czarcinski wrote: This patch adds support for adding a static route for a network. The via specifies the gateway's IP address. Both IPv4 and IPv6 static routes are supported although it is expected that this

[libvirt] [PATCH] v2:Support for adding a static route to a bridge

2013-03-15 Thread Gene Czarcinski
This patch adds support for adding a static route for a network. The via specifies the gateway's IP address. Both IPv4 and IPv6 static routes are supported although it is expected that this functionality will have more use with IPv6. Extensive tests are done to validate that the input

Re: [libvirt] [PATCH] v2:Support for adding a static route to a bridge

2013-03-15 Thread Gene Czarcinski
On 03/15/2013 02:10 PM, Gene Czarcinski wrote: This patch adds support for adding a static route for a network. The via specifies the gateway's IP address. Both IPv4 and IPv6 static routes are supported although it is expected that this functionality will have more use with IPv6. Extensive