Re: [libvirt] [PATCH] virDomainShutdown*: Describe blocking behaviour

2015-03-31 Thread Eric Blake
On 03/31/2015 01:37 AM, Michal Privoznik wrote: >> I don't think this is the right approach. It is okay to block for a >> small finite amount of time, but if the guest agent really is something >> that can hang, we should fix that code to return without waiting for the >> agent response. >> > >

Re: [libvirt] [PATCH] virDomainShutdown*: Describe blocking behaviour

2015-03-31 Thread Michal Privoznik
On 30.03.2015 22:38, Eric Blake wrote: > On 03/30/2015 06:07 AM, Michal Privoznik wrote: >> The description to both virDomainShutdown() and >> virDomainShutdownFlags() is quite misleading when it comes to >> blocking behaviour of these two APIs. Firstly, we support many >> shutdown methods, from si

Re: [libvirt] [PATCH] virDomainShutdown*: Describe blocking behaviour

2015-03-30 Thread Eric Blake
On 03/30/2015 06:07 AM, Michal Privoznik wrote: > The description to both virDomainShutdown() and > virDomainShutdownFlags() is quite misleading when it comes to > blocking behaviour of these two APIs. Firstly, we support many > shutdown methods, from signalizing an ACPI event, through sending > a

[libvirt] [PATCH] virDomainShutdown*: Describe blocking behaviour

2015-03-30 Thread Michal Privoznik
The description to both virDomainShutdown() and virDomainShutdownFlags() is quite misleading when it comes to blocking behaviour of these two APIs. Firstly, we support many shutdown methods, from signalizing an ACPI event, through sending a signal to guest agent assisted shutdown. Some of these met