[libvirt] [PATCH] virsh: add --start option to the define command

2013-02-24 Thread Doug Goldstein
Adds the --start option to the define command to simplify the often used case of virsh define dom.xml; start dom or virsh define dom.xml virsh start dom. This is just a rebased version of: https://www.redhat.com/archives/libvir-list/2013-January/msg00490.html There's a competing patchset

Re: [libvirt] [PATCH] virsh: add --start option to the define command

2013-02-21 Thread Peter Krempa
On 02/18/13 06:11, Doug Goldstein wrote: On Fri, Jan 11, 2013 at 2:51 PM, Guido Günther a...@sigxcpu.org wrote: On Tue, Jan 08, 2013 at 04:41:58PM -0700, Eric Blake wrote: On 01/08/2013 02:36 PM, Doug Goldstein wrote: I often find myself doing virsh define blah.xml; start blah. I figured

Re: [libvirt] [PATCH] virsh: add --start option to the define command

2013-02-21 Thread Doug Goldstein
On Thu, Feb 21, 2013 at 9:55 AM, Peter Krempa pkre...@redhat.com wrote: On 02/18/13 06:11, Doug Goldstein wrote: On Fri, Jan 11, 2013 at 2:51 PM, Guido Günther a...@sigxcpu.org wrote: On Tue, Jan 08, 2013 at 04:41:58PM -0700, Eric Blake wrote: On 01/08/2013 02:36 PM, Doug Goldstein wrote:

Re: [libvirt] [PATCH] virsh: add --start option to the define command

2013-02-17 Thread Doug Goldstein
On Fri, Jan 11, 2013 at 2:51 PM, Guido Günther a...@sigxcpu.org wrote: On Tue, Jan 08, 2013 at 04:41:58PM -0700, Eric Blake wrote: On 01/08/2013 02:36 PM, Doug Goldstein wrote: I often find myself doing virsh define blah.xml; start blah. I figured adding this would be a easier^Hlazier way to

Re: [libvirt] [PATCH] virsh: add --start option to the define command

2013-01-11 Thread Guido Günther
On Tue, Jan 08, 2013 at 04:41:58PM -0700, Eric Blake wrote: On 01/08/2013 02:36 PM, Doug Goldstein wrote: I often find myself doing virsh define blah.xml; start blah. I figured adding this would be a easier^Hlazier way to do it. --- tools/virsh-domain.c | 20 ++-- 1

Re: [libvirt] [PATCH] virsh: add --start option to the define command

2013-01-09 Thread Viktor Mihajlovski
On 01/09/2013 12:41 AM, Eric Blake wrote: But if we do that, it would argue that 'virsh create --persistent blah.xml' is nicer than 'virsh define --start blah.xml', at least in that the former needs only 1 API call for new libvirt (but falls back to 2 API calls when talking to older libvirt),

Re: [libvirt] [PATCH] virsh: add --start option to the define command

2013-01-09 Thread Daniel P. Berrange
On Tue, Jan 08, 2013 at 04:41:58PM -0700, Eric Blake wrote: On 01/08/2013 02:36 PM, Doug Goldstein wrote: I often find myself doing virsh define blah.xml; start blah. I figured adding this would be a easier^Hlazier way to do it. --- tools/virsh-domain.c | 20 ++-- 1

Re: [libvirt] [PATCH] virsh: add --start option to the define command

2013-01-09 Thread Eric Blake
On 01/09/2013 03:28 AM, Daniel P. Berrange wrote: We have virDomainDefineXML with no flags, but we have virDomainCreateXML with flags; maybe the better approach is to add a new creation flag that says that in addition to starting the domain, we also make it persistent at the same time. But

Re: [libvirt] [PATCH] virsh: add --start option to the define command

2013-01-09 Thread Daniel P. Berrange
On Wed, Jan 09, 2013 at 09:49:31AM -0700, Eric Blake wrote: On 01/09/2013 03:28 AM, Daniel P. Berrange wrote: We have virDomainDefineXML with no flags, but we have virDomainCreateXML with flags; maybe the better approach is to add a new creation flag that says that in addition to starting

[libvirt] [PATCH] virsh: add --start option to the define command

2013-01-08 Thread Doug Goldstein
I often find myself doing virsh define blah.xml; start blah. I figured adding this would be a easier^Hlazier way to do it. --- tools/virsh-domain.c | 20 ++-- 1 files changed, 18 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index

Re: [libvirt] [PATCH] virsh: add --start option to the define command

2013-01-08 Thread Eric Blake
On 01/08/2013 02:36 PM, Doug Goldstein wrote: I often find myself doing virsh define blah.xml; start blah. I figured adding this would be a easier^Hlazier way to do it. --- tools/virsh-domain.c | 20 ++-- 1 files changed, 18 insertions(+), 2 deletions(-) Offhand, I like

Re: [libvirt] [PATCH] virsh: add --start option to the define command

2013-01-08 Thread Doug Goldstein
On Tue, Jan 8, 2013 at 5:41 PM, Eric Blake ebl...@redhat.com wrote: On 01/08/2013 02:36 PM, Doug Goldstein wrote: I often find myself doing virsh define blah.xml; start blah. I figured adding this would be a easier^Hlazier way to do it. --- tools/virsh-domain.c | 20 ++--