Re: [libvirt] [PATCH] vshReadlineOptionsPrune: Fix possible leak

2018-01-15 Thread Michal Privoznik
On 01/12/2018 10:07 PM, John Ferlan wrote: > > > On 01/12/2018 11:08 AM, Michal Privoznik wrote: >> The function should prune list of --options so that options >> already specified are not offered to user for completion again. >> However, if the list of offered options contains a string that >> d

Re: [libvirt] [PATCH] vshReadlineOptionsPrune: Fix possible leak

2018-01-12 Thread John Ferlan
On 01/12/2018 11:08 AM, Michal Privoznik wrote: > The function should prune list of --options so that options > already specified are not offered to user for completion again. > However, if the list of offered options contains a string that > doesn't start with double dash the function returns le

[libvirt] [PATCH] vshReadlineOptionsPrune: Fix possible leak

2018-01-12 Thread Michal Privoznik
The function should prune list of --options so that options already specified are not offered to user for completion again. However, if the list of offered options contains a string that doesn't start with double dash the function returns leaking partially constructed list. There's not much benefit