[libvirt] [PATCH 0/3 TCK] Some tests for snapshot management

2011-08-26 Thread Daniel P. Berrange
All these tests fail with current GIT, but are intended to work with Eric's snapshot series applied. The first test in this list, however, does not pass. Eric's current tree forbids calling 'Destroy' on a transient guest which has snapshots present. IMHO this is wrong, because the guest may

Re: [libvirt] [PATCH 0/3 TCK] Some tests for snapshot management

2011-08-26 Thread Eric Blake
On 08/26/2011 08:16 AM, Daniel P. Berrange wrote: All these tests fail with current GIT, but are intended to work with Eric's snapshot series applied. The first test in this list, however, does not pass. Eric's current tree forbids calling 'Destroy' on a transient guest which has snapshots

Re: [libvirt] [PATCH 0/3 TCK] Some tests for snapshot management

2011-08-26 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 08:57:54AM -0600, Eric Blake wrote: On 08/26/2011 08:16 AM, Daniel P. Berrange wrote: All these tests fail with current GIT, but are intended to work with Eric's snapshot series applied. The first test in this list, however, does not pass. Eric's current tree

Re: [libvirt] [PATCH 0/3 TCK] Some tests for snapshot management

2011-08-26 Thread Eric Blake
On 08/26/2011 09:03 AM, Daniel P. Berrange wrote: IMHO, we should be allowed to call 'virDomainDestroy' on a transient guest with snapshots, and then later 'virDomainCreateXML' to re-create the guest and still have access to the snapshots But leaving the snapshot metadata files behind is

Re: [libvirt] [PATCH 0/3 TCK] Some tests for snapshot management

2011-08-26 Thread Daniel P. Berrange
On Fri, Aug 26, 2011 at 09:15:43AM -0600, Eric Blake wrote: On 08/26/2011 09:03 AM, Daniel P. Berrange wrote: IMHO, we should be allowed to call 'virDomainDestroy' on a transient guest with snapshots, and then later 'virDomainCreateXML' to re-create the guest and still have access to the