Re: [libvirt] [PATCH 00/11] Avoid numerous calls of virQEMUCapsCacheLookup

2018-10-26 Thread Daniel P . Berrangé
On Fri, Oct 26, 2018 at 06:57:54AM +0200, Bjoern Walk wrote: > Daniel P. Berrangé [2018-10-25, 06:32PM +0100]: > > On Thu, Oct 25, 2018 at 01:47:26PM +0200, Bjoern Walk wrote: > > > Daniel P. Berrangé [2018-10-24, 10:43PM +0100]: > > > > We could optimize this by jcalling virFileAccessibleAs > >

Re: [libvirt] [PATCH 00/11] Avoid numerous calls of virQEMUCapsCacheLookup

2018-10-26 Thread Marc Hartmayer
On Wed, Oct 24, 2018 at 11:43 PM +0200, "Daniel P. Berrangé" wrote: > On Thu, Sep 20, 2018 at 07:44:46PM +0200, Marc Hartmayer wrote: >> For a domain definition there are numerous calls of >> virQEMUCapsCacheLookup (the same applies to the domain start). This >> slows down the process since

Re: [libvirt] [PATCH 00/11] Avoid numerous calls of virQEMUCapsCacheLookup

2018-10-25 Thread Bjoern Walk
Daniel P. Berrangé [2018-10-25, 06:32PM +0100]: > On Thu, Oct 25, 2018 at 01:47:26PM +0200, Bjoern Walk wrote: > > Daniel P. Berrangé [2018-10-24, 10:43PM +0100]: > > > We could optimize this by jcalling virFileAccessibleAs > > > once and storing the result in a global. Then just do a > > >

Re: [libvirt] [PATCH 00/11] Avoid numerous calls of virQEMUCapsCacheLookup

2018-10-25 Thread Daniel P . Berrangé
On Thu, Oct 25, 2018 at 01:47:26PM +0200, Bjoern Walk wrote: > Daniel P. Berrangé [2018-10-24, 10:43PM +0100]: > > We could optimize this by jcalling virFileAccessibleAs > > once and storing the result in a global. Then just do a > > plain stat() call in process to check the st_ctime field > >

Re: [libvirt] [PATCH 00/11] Avoid numerous calls of virQEMUCapsCacheLookup

2018-10-25 Thread Bjoern Walk
Daniel P. Berrangé [2018-10-24, 10:43PM +0100]: > We could optimize this by jcalling virFileAccessibleAs > once and storing the result in a global. Then just do a > plain stat() call in process to check the st_ctime field > for changes. We only need re-run the heavy virFileAccessibleAs > check if

Re: [libvirt] [PATCH 00/11] Avoid numerous calls of virQEMUCapsCacheLookup

2018-10-24 Thread Daniel P . Berrangé
On Thu, Sep 20, 2018 at 07:44:46PM +0200, Marc Hartmayer wrote: > For a domain definition there are numerous calls of > virQEMUCapsCacheLookup (the same applies to the domain start). This > slows down the process since virQEMUCapsCacheLookup validates that the > QEMU capabilitites are still valid

[libvirt] [PATCH 00/11] Avoid numerous calls of virQEMUCapsCacheLookup

2018-09-20 Thread Marc Hartmayer
For a domain definition there are numerous calls of virQEMUCapsCacheLookup (the same applies to the domain start). This slows down the process since virQEMUCapsCacheLookup validates that the QEMU capabilitites are still valid (among other things, a fork is done for this if the user for the QEMU