Re: [libvirt] [PATCH 01/10] nwfilter: don't ignore child process failures

2014-02-21 Thread Laine Stump
On 02/20/2014 07:13 AM, Eric Blake wrote: While auditing all callers of virCommandRun, I noticed that nwfilter code never paid attention to commands with a non-zero status. In the cases where status was captured, either the callers required that the status was 0, or they discarded any failures

Re: [libvirt] [PATCH 01/10] nwfilter: don't ignore child process failures

2014-02-21 Thread Eric Blake
On 02/21/2014 04:20 AM, Laine Stump wrote: On 02/20/2014 07:13 AM, Eric Blake wrote: While auditing all callers of virCommandRun, I noticed that nwfilter code never paid attention to commands with a non-zero status. In the cases where status was captured, either the callers required that the

[libvirt] [PATCH 01/10] nwfilter: don't ignore child process failures

2014-02-19 Thread Eric Blake
While auditing all callers of virCommandRun, I noticed that nwfilter code never paid attention to commands with a non-zero status. In the cases where status was captured, either the callers required that the status was 0, or they discarded any failures from virCommandRun. Collecting status