Re: [libvirt] [PATCH 01/10] qemu: snapshot: Don't modify persistent XML if disk source is different

2019-08-21 Thread Ján Tomko
On Fri, Aug 16, 2019 at 03:54:35PM +0200, Peter Krempa wrote: While the VM is running the persistent source of a disk might differ e.g. as the 'newDef' was redefined. Our snapshot code would blindly rewrite the source of such disk if it shared the 'target'. Fix this by checking whether the

[libvirt] [PATCH 01/10] qemu: snapshot: Don't modify persistent XML if disk source is different

2019-08-16 Thread Peter Krempa
While the VM is running the persistent source of a disk might differ e.g. as the 'newDef' was redefined. Our snapshot code would blindly rewrite the source of such disk if it shared the 'target'. Fix this by checking whether the source is the same in the first place. Signed-off-by: Peter Krempa