Re: [libvirt] [PATCH 01/13] qemu: fix use-after-free when parsing NBD disk

2013-02-28 Thread Paolo Bonzini
Il 28/02/2013 06:03, Eric Blake ha scritto: diff --git i/src/qemu/qemu_command.c w/src/qemu/qemu_command.c index 0a7d4ec..f8f3ade 100644 --- i/src/qemu/qemu_command.c +++ w/src/qemu/qemu_command.c @@ -8832,11 +8832,11 @@ virDomainDefPtr qemuParseCommandLine(virCapsPtr qemuCaps,

Re: [libvirt] [PATCH 01/13] qemu: fix use-after-free when parsing NBD disk

2013-02-27 Thread Eric Blake
On 02/25/2013 10:44 AM, Paolo Bonzini wrote: disk-src is still used for disks-hosts-name, do not free it. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- src/qemu/qemu_command.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c

Re: [libvirt] [PATCH 01/13] qemu: fix use-after-free when parsing NBD disk

2013-02-27 Thread Eric Blake
On 02/27/2013 10:03 PM, Eric Blake wrote: So there is definitely a use-after-free bug fixed by your patch. However, your patch causes a double-free bug on error (if the Rather, your patch did nothing to address the pre-existing double-free bug on error. Guess I should be more careful when

[libvirt] [PATCH 01/13] qemu: fix use-after-free when parsing NBD disk

2013-02-25 Thread Paolo Bonzini
disk-src is still used for disks-hosts-name, do not free it. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- src/qemu/qemu_command.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index dee493f..5dccaae 100644 ---