Re: [libvirt] [PATCH 03/12] domain: add implicit controllers from post parse

2016-01-08 Thread Peter Krempa
On Thu, Jan 07, 2016 at 22:49:57 -0500, Cole Robinson wrote: > Seems like the natural fit, since we are already adding other XML bits > in the PostParse routine. > > Previously AddImplicitControllers was only called at the end of XML > parsing, meaning code that builds a DomainDef by hand had to

Re: [libvirt] [PATCH 03/12] domain: add implicit controllers from post parse

2016-01-08 Thread Cole Robinson
On 01/08/2016 07:05 AM, Peter Krempa wrote: > On Thu, Jan 07, 2016 at 22:49:57 -0500, Cole Robinson wrote: >> Seems like the natural fit, since we are already adding other XML bits >> in the PostParse routine. >> >> Previously AddImplicitControllers was only called at the end of XML >> parsing,

[libvirt] [PATCH 03/12] domain: add implicit controllers from post parse

2016-01-07 Thread Cole Robinson
Seems like the natural fit, since we are already adding other XML bits in the PostParse routine. Previously AddImplicitControllers was only called at the end of XML parsing, meaning code that builds a DomainDef by hand had to manually call it. Adding it for those sites causes some test suite