Re: [libvirt] [PATCH 05/10] qemu: agent: straigten up failed agent start case

2016-10-27 Thread Nikolay Shirokovskiy
On 26.10.2016 23:04, John Ferlan wrote: > > > On 10/04/2016 02:56 AM, Nikolay Shirokovskiy wrote: >> agentError is used for 2 different cases: >> >> 1. agent monitor is failed to start > > Non guest fatal failure in qemuConnectAgent when first trying to connect > to the agent > >> 2. io

Re: [libvirt] [PATCH 05/10] qemu: agent: straigten up failed agent start case

2016-10-26 Thread John Ferlan
On 10/04/2016 02:56 AM, Nikolay Shirokovskiy wrote: > agentError is used for 2 different cases: > > 1. agent monitor is failed to start Non guest fatal failure in qemuConnectAgent when first trying to connect to the agent > 2. io error in agent monitor I/O error with running agent resulting

[libvirt] [PATCH 05/10] qemu: agent: straigten up failed agent start case

2016-10-04 Thread Nikolay Shirokovskiy
agentError is used for 2 different cases: 1. agent monitor is failed to start 2. io error in agent monitor Actually to check for the first case we don't need the flag at all. NULL agent is always error for old qemu (QEMU_CAPS_VSERPORT_CHANGE is not supported), while for modern qemu it is an