Re: [libvirt] [PATCH 07/21] qemu_hotplug: refactor qemuDomainDetachDiskLive and qemuDomainDetachDiskDevice

2019-03-22 Thread Laine Stump
On 3/22/19 5:07 AM, Peter Krempa wrote: On Thu, Mar 21, 2019 at 18:28:47 -0400, Laine Stump wrote: qemuDomainDetachDiskDevice() is only called from one place. Moving the contents of the function to that place makes qemuDomainDetachDiskLive() more similar to the other Detach functions called by

Re: [libvirt] [PATCH 07/21] qemu_hotplug: refactor qemuDomainDetachDiskLive and qemuDomainDetachDiskDevice

2019-03-22 Thread Peter Krempa
On Thu, Mar 21, 2019 at 18:28:47 -0400, Laine Stump wrote: > qemuDomainDetachDiskDevice() is only called from one place. Moving the > contents of the function to that place makes > qemuDomainDetachDiskLive() more similar to the other Detach functions > called by the toplevel

[libvirt] [PATCH 07/21] qemu_hotplug: refactor qemuDomainDetachDiskLive and qemuDomainDetachDiskDevice

2019-03-21 Thread Laine Stump
qemuDomainDetachDiskDevice() is only called from one place. Moving the contents of the function to that place makes qemuDomainDetachDiskLive() more similar to the other Detach functions called by the toplevel qemuDomainDetachDevice(). The goal is to make each of the device-type-specific functions