Re: [libvirt] [PATCH 08/10] qemu: Add ability to abort existing console while creating new one

2011-10-18 Thread Daniel P. Berrange
On Wed, Oct 12, 2011 at 03:43:18PM +0200, Peter Krempa wrote: This patch fixes console corruption, that happens if two concurrent sessions are opened for a single console on a domain. Result of this corruption was, that each of the console streams did recieve just a part of the data written to

Re: [libvirt] [PATCH 08/10] qemu: Add ability to abort existing console while creating new one

2011-10-18 Thread Peter Krempa
On 10/18/2011 12:23 PM, Daniel P. Berrange wrote: Hmm, I have a feeling this will cause a leak. Currently the virStreamPtr reference is held by the daemon itself, and when the client disconnects it free's the stream. With this extra reference held by the QEMU driver, the virStreamPtr will live

[libvirt] [PATCH 08/10] qemu: Add ability to abort existing console while creating new one

2011-10-12 Thread Peter Krempa
This patch fixes console corruption, that happens if two concurrent sessions are opened for a single console on a domain. Result of this corruption was, that each of the console streams did recieve just a part of the data written to the pipe so every console rendered unusable. This patch adds a