Re: [libvirt] [PATCH 1/1] IDE: deprecate ide-drive

2019-10-09 Thread John Snow
On 10/8/19 2:51 AM, Markus Armbruster wrote: >> I'll respin to hit the tests with a stiffer scrub-brush. > Thanks! 051 is the only test I can find that uses ide-drive, and the non-pc version of the test doesn't seem to use it, so this actually seems sufficient. I'd like to keep the test for

Re: [libvirt] [PATCH 1/1] IDE: deprecate ide-drive

2019-10-08 Thread Markus Armbruster
John Snow writes: > On 10/7/19 5:49 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> It's an old compatibility shim that just delegates to ide-cd or ide-hd. >>> I'd like to refactor these some day, and getting rid of the super-object >>> will make that easier. >> >> Device "scsi-disk"

Re: [libvirt] [PATCH 1/1] IDE: deprecate ide-drive

2019-10-07 Thread John Snow
On 10/7/19 5:49 AM, Markus Armbruster wrote: > John Snow writes: > >> It's an old compatibility shim that just delegates to ide-cd or ide-hd. >> I'd like to refactor these some day, and getting rid of the super-object >> will make that easier. > > Device "scsi-disk" is similar. However,

Re: [libvirt] [PATCH 1/1] IDE: deprecate ide-drive

2019-10-07 Thread Markus Armbruster
John Snow writes: > It's an old compatibility shim that just delegates to ide-cd or ide-hd. > I'd like to refactor these some day, and getting rid of the super-object > will make that easier. Device "scsi-disk" is similar. However, it's still used by the scsi_bus_legacy_add_drive() magic. Not

Re: [libvirt] [PATCH 1/1] IDE: deprecate ide-drive

2019-10-07 Thread Peter Krempa
On Sun, Oct 06, 2019 at 16:31:50 -0400, John Snow wrote: > It's an old compatibility shim that just delegates to ide-cd or ide-hd. > I'd like to refactor these some day, and getting rid of the super-object > will make that easier. > > Either way, we don't need this. > > Signed-off-by: John Snow

[libvirt] [PATCH 1/1] IDE: deprecate ide-drive

2019-10-06 Thread John Snow
It's an old compatibility shim that just delegates to ide-cd or ide-hd. I'd like to refactor these some day, and getting rid of the super-object will make that easier. Either way, we don't need this. Signed-off-by: John Snow --- qemu-deprecated.texi | 5 + hw/ide/qdev.c