Re: [libvirt] [PATCH 1/1] tests: xmconfigtest: Add test for os.cmdline

2018-05-22 Thread filip aláč
It may be worth to take a look at files test-paravirt-cmdline,cmdline-bogus-extra...etc. in tests/xlconfigdata. They look they are testing the same/similiar problem. Feel free to to make v2, Thanks. 2018-05-22 1:57 GMT+02:00 Jim Fehlig : > On 05/21/2018 05:57 AM, Filip Alac

Re: [libvirt] [PATCH 1/1] tests: xmconfigtest: Add test for os.cmdline

2018-05-21 Thread Jim Fehlig
On 05/21/2018 05:57 AM, Filip Alac wrote: Add test case for the os cmdline. Check if: 656151bf5dd299322dcf37d06d20534e667a1963 work as expected. Thanks for taking up Cole's suggestion! I had added it to my todo list. To test the code you fixed in 656151bf, we need to check the following 1.

[libvirt] [PATCH 1/1] tests: xmconfigtest: Add test for os.cmdline

2018-05-21 Thread Filip Alac
Add test case for the os cmdline. Check if: 656151bf5dd299322dcf37d06d20534e667a1963 work as expected. Signed-off-by: Filip Alac --- tests/xmconfigdata/test-os-cmdline.cfg | 14 + tests/xmconfigdata/test-os-cmdline.xml | 40 ++