Re: [libvirt] [PATCH 1/2] build: virrandommock.c not needed on mingw

2016-07-12 Thread Eric Blake
On 07/12/2016 03:27 AM, Martin Kletzander wrote: > On Mon, Jul 11, 2016 at 09:55:00PM -0600, Eric Blake wrote: >> We can't mock tests on Mingw, which lacks dlopen() and friends; >> follow the paradigms used in other mock files of conditionally >> compiling nothing when not building for Linux. >>

Re: [libvirt] [PATCH 1/2] build: virrandommock.c not needed on mingw

2016-07-12 Thread Martin Kletzander
On Tue, Jul 12, 2016 at 10:45:12AM +0100, Daniel P. Berrange wrote: On Tue, Jul 12, 2016 at 11:27:43AM +0200, Martin Kletzander wrote: On Mon, Jul 11, 2016 at 09:55:00PM -0600, Eric Blake wrote: > We can't mock tests on Mingw, which lacks dlopen() and friends; > follow the paradigms used in

Re: [libvirt] [PATCH 1/2] build: virrandommock.c not needed on mingw

2016-07-12 Thread Daniel P. Berrange
On Tue, Jul 12, 2016 at 11:27:43AM +0200, Martin Kletzander wrote: > On Mon, Jul 11, 2016 at 09:55:00PM -0600, Eric Blake wrote: > > We can't mock tests on Mingw, which lacks dlopen() and friends; > > follow the paradigms used in other mock files of conditionally > > compiling nothing when not

Re: [libvirt] [PATCH 1/2] build: virrandommock.c not needed on mingw

2016-07-12 Thread Martin Kletzander
On Mon, Jul 11, 2016 at 09:55:00PM -0600, Eric Blake wrote: We can't mock tests on Mingw, which lacks dlopen() and friends; follow the paradigms used in other mock files of conditionally compiling nothing when not building for Linux. Signed-off-by: Eric Blake ---

Re: [libvirt] [PATCH 1/2] build: virrandommock.c not needed on mingw

2016-07-12 Thread Daniel P. Berrange
On Mon, Jul 11, 2016 at 09:55:00PM -0600, Eric Blake wrote: > We can't mock tests on Mingw, which lacks dlopen() and friends; > follow the paradigms used in other mock files of conditionally > compiling nothing when not building for Linux. > > Signed-off-by: Eric Blake > --- >

[libvirt] [PATCH 1/2] build: virrandommock.c not needed on mingw

2016-07-11 Thread Eric Blake
We can't mock tests on Mingw, which lacks dlopen() and friends; follow the paradigms used in other mock files of conditionally compiling nothing when not building for Linux. Signed-off-by: Eric Blake --- tests/virrandommock.c | 19 --- 1 file changed, 12