Re: [libvirt] [PATCH 1/2] conf: Detect misconfiguration between disk bus and disk address

2016-11-16 Thread Marc Hartmayer
On Wed, Nov 16, 2016 at 09:09 AM +0100, Peter Krempa wrote: >> +{ >> +if (addressType == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) >> +return true; >> + >> +switch (bus) { >> +case VIR_DOMAIN_DISK_BUS_SATA: >> +case VIR_DOMAIN_DISK_BUS_SCSI: >> +case VIR_DOMAIN_DISK_BUS_FDC:

Re: [libvirt] [PATCH 1/2] conf: Detect misconfiguration between disk bus and disk address

2016-11-16 Thread Peter Krempa
On Tue, Nov 15, 2016 at 19:40:58 +0100, Marc Hartmayer wrote: > This patch detects a misconfiguration between the disk bus type and disk > address type for controller based disk buses (SATA, SCSI, FDC and > IDE). The addresses of these bus types are all managed in common code so > it's possible to

[libvirt] [PATCH 1/2] conf: Detect misconfiguration between disk bus and disk address

2016-11-15 Thread Marc Hartmayer
This patch detects a misconfiguration between the disk bus type and disk address type for controller based disk buses (SATA, SCSI, FDC and IDE). The addresses of these bus types are all managed in common code so it's possible to decide in common code whether the disk address and bus type are compat