On Wed, 2018-11-14 at 11:13 +0100, Vitaly Kuznetsov wrote:
> Andrea Bolognani writes:
> ...
> > > + 4.10.0 (QEMU 3.1)
> >
> > Again pre-existing: what does the first version number refer to? It
> > would be nice to have it spelled out.
>
> My understanding is that this is libvirt
Andrea Bolognani writes:
...
>
>> + 4.10.0 (QEMU 3.1)
>
> Again pre-existing: what does the first version number refer to? It
> would be nice to have it spelled out.
>
My understanding is that this is libvirt version. We can, of course,
spell it out but:
$ git grep -c 'class="since"'
On Wed, 2018-11-14 at 10:00 +0100, Andrea Bolognani wrote:
> On Tue, 2018-11-13 at 18:53 +0100, Vitaly Kuznetsov wrote:
> > Qemu-3.1 supports Hyper-V-style PV IPIs making it cheaper for Windows
>
> s/Qemu-3.1/QEMU 3.1/
>
> [...]
> > +
> > + ipi
> > + Enable PV IPI
On Tue, 2018-11-13 at 18:53 +0100, Vitaly Kuznetsov wrote:
> Qemu-3.1 supports Hyper-V-style PV IPIs making it cheaper for Windows
s/Qemu-3.1/QEMU 3.1/
[...]
> +
> + ipi
> + Enable PV IPI support
> + on, off
s/ on,/on,/
Everything else looks good.
--
On Tue, 2018-11-13 at 18:53 +0100, Vitaly Kuznetsov wrote:
> Qemu-3.1 supports Hyper-V-style PV IPIs making it cheaper for Windows
s/Qemu-3.1/QEMU 3.1/
[...]
> +
> + ipi
> + Enable PV IPI support
> + on, off
No whitespace before "on", please.
Pre-existing:
Qemu-3.1 supports Hyper-V-style PV IPIs making it cheaper for Windows
guests to send an IPI, especially when it targets many CPUs.
Signed-off-by: Vitaly Kuznetsov
---
docs/formatdomain.html.in | 7 +++
docs/schemas/domaincommon.rng | 5 +
src/conf/domain_conf.c
