Re: [libvirt] [PATCH 1/2] qemu: Save qemuDomainGetStats error

2018-12-06 Thread John Ferlan
On 12/6/18 10:15 AM, Ján Tomko wrote: > On Thu, Dec 06, 2018 at 02:49:59PM +0100, Ján Tomko wrote: >> On Tue, Nov 27, 2018 at 11:23:22AM -0500, John Ferlan wrote: >>> During qemuConnectGetAllDomainStats if qemuDomainGetStats causes >>> a failure, then when collecting more than one domain's worth

Re: [libvirt] [PATCH 1/2] qemu: Save qemuDomainGetStats error

2018-12-06 Thread Ján Tomko
On Thu, Dec 06, 2018 at 02:49:59PM +0100, Ján Tomko wrote: On Tue, Nov 27, 2018 at 11:23:22AM -0500, John Ferlan wrote: During qemuConnectGetAllDomainStats if qemuDomainGetStats causes a failure, then when collecting more than one domain's worth of statistics the loop in virDomainStatsRecordList

Re: [libvirt] [PATCH 1/2] qemu: Save qemuDomainGetStats error

2018-12-06 Thread Ján Tomko
On Tue, Nov 27, 2018 at 11:23:22AM -0500, John Ferlan wrote: During qemuConnectGetAllDomainStats if qemuDomainGetStats causes a failure, then when collecting more than one domain's worth of statistics the loop in virDomainStatsRecordListFree would call virDomainFree which would call virResetLastE

Re: [libvirt] [PATCH 1/2] qemu: Save qemuDomainGetStats error

2018-11-28 Thread Erik Skultety
On Wed, Nov 28, 2018 at 12:28:21PM +, Daniel P. Berrangé wrote: > On Wed, Nov 28, 2018 at 01:26:17PM +0100, Erik Skultety wrote: > > On Wed, Nov 28, 2018 at 12:08:51PM +, Daniel P. Berrangé wrote: > > > On Wed, Nov 28, 2018 at 12:49:14PM +0100, Erik Skultety wrote: > > > > On Tue, Nov 27, 2

Re: [libvirt] [PATCH 1/2] qemu: Save qemuDomainGetStats error

2018-11-28 Thread Erik Skultety
On Wed, Nov 28, 2018 at 12:08:51PM +, Daniel P. Berrangé wrote: > On Wed, Nov 28, 2018 at 12:49:14PM +0100, Erik Skultety wrote: > > On Tue, Nov 27, 2018 at 11:23:22AM -0500, John Ferlan wrote: > > > During qemuConnectGetAllDomainStats if qemuDomainGetStats causes > > > a failure, then when col

Re: [libvirt] [PATCH 1/2] qemu: Save qemuDomainGetStats error

2018-11-28 Thread Daniel P . Berrangé
On Wed, Nov 28, 2018 at 01:26:17PM +0100, Erik Skultety wrote: > On Wed, Nov 28, 2018 at 12:08:51PM +, Daniel P. Berrangé wrote: > > On Wed, Nov 28, 2018 at 12:49:14PM +0100, Erik Skultety wrote: > > > On Tue, Nov 27, 2018 at 11:23:22AM -0500, John Ferlan wrote: > > > > During qemuConnectGetAll

Re: [libvirt] [PATCH 1/2] qemu: Save qemuDomainGetStats error

2018-11-28 Thread Daniel P . Berrangé
On Wed, Nov 28, 2018 at 12:49:14PM +0100, Erik Skultety wrote: > On Tue, Nov 27, 2018 at 11:23:22AM -0500, John Ferlan wrote: > > During qemuConnectGetAllDomainStats if qemuDomainGetStats causes > > a failure, then when collecting more than one domain's worth of > > statistics the loop in virDomain

Re: [libvirt] [PATCH 1/2] qemu: Save qemuDomainGetStats error

2018-11-28 Thread Erik Skultety
On Tue, Nov 27, 2018 at 11:23:22AM -0500, John Ferlan wrote: > During qemuConnectGetAllDomainStats if qemuDomainGetStats causes > a failure, then when collecting more than one domain's worth of > statistics the loop in virDomainStatsRecordListFree would call > virDomainFree which would call virRese

[libvirt] [PATCH 1/2] qemu: Save qemuDomainGetStats error

2018-11-27 Thread John Ferlan
During qemuConnectGetAllDomainStats if qemuDomainGetStats causes a failure, then when collecting more than one domain's worth of statistics the loop in virDomainStatsRecordListFree would call virDomainFree which would call virResetLastError effectively wiping out the reason we failed leaving the ca