Re: [libvirt] [PATCH 1/2] qemu: fix some small issue in qemuProcessAttach

2014-12-03 Thread Luyao Huang
To: Luyao Huang lhu...@redhat.com Cc: libvir-list@redhat.com Sent: Monday, December 1, 2014 11:41:59 PM Subject: Re: [libvirt] [PATCH 1/2] qemu: fix some small issue in qemuProcessAttach On Mon, Dec 01, 2014 at 11:30:09PM +0800, Luyao Huang wrote: On 12/01/2014 06:27 PM, Martin Kletzander wrote

[libvirt] [PATCH 1/2] qemu: fix some small issue in qemuProcessAttach

2014-12-01 Thread Luyao Huang
There are some small issue in qemuProcessAttach: 1.Fix virSecurityManagerGetProcessLabel always get pid = 0, move 'vm-pid = pid' before call virSecurityManagerGetProcessLabel. 2.Use virSecurityManagerGenLabel to get image label. 3.Fix always set selinux label for other security driver label.

Re: [libvirt] [PATCH 1/2] qemu: fix some small issue in qemuProcessAttach

2014-12-01 Thread Martin Kletzander
On Mon, Dec 01, 2014 at 05:54:35PM +0800, Luyao Huang wrote: There are some small issue in qemuProcessAttach: 1.Fix virSecurityManagerGetProcessLabel always get pid = 0, move 'vm-pid = pid' before call virSecurityManagerGetProcessLabel. 2.Use virSecurityManagerGenLabel to get image label.

Re: [libvirt] [PATCH 1/2] qemu: fix some small issue in qemuProcessAttach

2014-12-01 Thread Martin Kletzander
On Mon, Dec 01, 2014 at 11:17:54AM +0100, Martin Kletzander wrote: On Mon, Dec 01, 2014 at 05:54:35PM +0800, Luyao Huang wrote: There are some small issue in qemuProcessAttach: 1.Fix virSecurityManagerGetProcessLabel always get pid = 0, move 'vm-pid = pid' before call

Re: [libvirt] [PATCH 1/2] qemu: fix some small issue in qemuProcessAttach

2014-12-01 Thread Luyao Huang
On 12/01/2014 06:27 PM, Martin Kletzander wrote: On Mon, Dec 01, 2014 at 11:17:54AM +0100, Martin Kletzander wrote: On Mon, Dec 01, 2014 at 05:54:35PM +0800, Luyao Huang wrote: There are some small issue in qemuProcessAttach: 1.Fix virSecurityManagerGetProcessLabel always get pid = 0, move

Re: [libvirt] [PATCH 1/2] qemu: fix some small issue in qemuProcessAttach

2014-12-01 Thread Martin Kletzander
On Mon, Dec 01, 2014 at 11:30:09PM +0800, Luyao Huang wrote: On 12/01/2014 06:27 PM, Martin Kletzander wrote: On Mon, Dec 01, 2014 at 11:17:54AM +0100, Martin Kletzander wrote: On Mon, Dec 01, 2014 at 05:54:35PM +0800, Luyao Huang wrote: There are some small issue in qemuProcessAttach: