Re: [libvirt] [PATCH 1/2] qemu: make sure capability probing process can start

2014-10-11 Thread Richard W.M. Jones
On Thu, Oct 09, 2014 at 10:14:48AM +0100, Daniel P. Berrange wrote: > On Thu, Oct 09, 2014 at 09:58:30AM +0200, Martin Kletzander wrote: > > When daemon is killed right in the middle of probing a qemu binary for > > its capabilities, the VM is left running. Next time the daemon is > > starting, it

Re: [libvirt] [PATCH 1/2] qemu: make sure capability probing process can start

2014-10-09 Thread Wang Rui
On 2014/10/9 19:08, Martin Kletzander wrote: > On Thu, Oct 09, 2014 at 11:52:49AM +0100, Daniel P. Berrange wrote: >> On Thu, Oct 09, 2014 at 12:37:42PM +0200, Jiri Denemark wrote: >>> On Thu, Oct 09, 2014 at 11:49:34 +0200, Martin Kletzander wrote: >>> > On Thu, Oct 09, 2014 at 10:14:48AM +0100, D

Re: [libvirt] [PATCH 1/2] qemu: make sure capability probing process can start

2014-10-09 Thread Martin Kletzander
On Thu, Oct 09, 2014 at 11:52:49AM +0100, Daniel P. Berrange wrote: On Thu, Oct 09, 2014 at 12:37:42PM +0200, Jiri Denemark wrote: On Thu, Oct 09, 2014 at 11:49:34 +0200, Martin Kletzander wrote: > On Thu, Oct 09, 2014 at 10:14:48AM +0100, Daniel P. Berrange wrote: > >On Thu, Oct 09, 2014 at 09:

Re: [libvirt] [PATCH 1/2] qemu: make sure capability probing process can start

2014-10-09 Thread Daniel P. Berrange
On Thu, Oct 09, 2014 at 11:49:34AM +0200, Martin Kletzander wrote: > On Thu, Oct 09, 2014 at 10:14:48AM +0100, Daniel P. Berrange wrote: > >On Thu, Oct 09, 2014 at 09:58:30AM +0200, Martin Kletzander wrote: > >>When daemon is killed right in the middle of probing a qemu binary for > >>its capabilit

Re: [libvirt] [PATCH 1/2] qemu: make sure capability probing process can start

2014-10-09 Thread Daniel P. Berrange
On Thu, Oct 09, 2014 at 12:37:42PM +0200, Jiri Denemark wrote: > On Thu, Oct 09, 2014 at 11:49:34 +0200, Martin Kletzander wrote: > > On Thu, Oct 09, 2014 at 10:14:48AM +0100, Daniel P. Berrange wrote: > > >On Thu, Oct 09, 2014 at 09:58:30AM +0200, Martin Kletzander wrote: > > >> When daemon is kil

Re: [libvirt] [PATCH 1/2] qemu: make sure capability probing process can start

2014-10-09 Thread Jiri Denemark
On Thu, Oct 09, 2014 at 11:49:34 +0200, Martin Kletzander wrote: > On Thu, Oct 09, 2014 at 10:14:48AM +0100, Daniel P. Berrange wrote: > >On Thu, Oct 09, 2014 at 09:58:30AM +0200, Martin Kletzander wrote: > >> When daemon is killed right in the middle of probing a qemu binary for > >> its capabilit

Re: [libvirt] [PATCH 1/2] qemu: make sure capability probing process can start

2014-10-09 Thread Jiri Denemark
On Thu, Oct 09, 2014 at 10:45:50 +0100, Daniel Berrange wrote: > On Thu, Oct 09, 2014 at 11:38:46AM +0200, Jiri Denemark wrote: > > On Thu, Oct 09, 2014 at 10:14:48 +0100, Daniel Berrange wrote: > > > On Thu, Oct 09, 2014 at 09:58:30AM +0200, Martin Kletzander wrote: > > > > When daemon is killed r

Re: [libvirt] [PATCH 1/2] qemu: make sure capability probing process can start

2014-10-09 Thread Martin Kletzander
On Thu, Oct 09, 2014 at 10:14:48AM +0100, Daniel P. Berrange wrote: On Thu, Oct 09, 2014 at 09:58:30AM +0200, Martin Kletzander wrote: When daemon is killed right in the middle of probing a qemu binary for its capabilities, the VM is left running. Next time the daemon is starting, it cannot sta

Re: [libvirt] [PATCH 1/2] qemu: make sure capability probing process can start

2014-10-09 Thread Daniel P. Berrange
On Thu, Oct 09, 2014 at 11:38:46AM +0200, Jiri Denemark wrote: > On Thu, Oct 09, 2014 at 10:14:48 +0100, Daniel Berrange wrote: > > On Thu, Oct 09, 2014 at 09:58:30AM +0200, Martin Kletzander wrote: > > > When daemon is killed right in the middle of probing a qemu binary for > > > its capabilities,

Re: [libvirt] [PATCH 1/2] qemu: make sure capability probing process can start

2014-10-09 Thread Jiri Denemark
On Thu, Oct 09, 2014 at 10:14:48 +0100, Daniel Berrange wrote: > On Thu, Oct 09, 2014 at 09:58:30AM +0200, Martin Kletzander wrote: > > When daemon is killed right in the middle of probing a qemu binary for > > its capabilities, the VM is left running. Next time the daemon is > > starting, it cann

Re: [libvirt] [PATCH 1/2] qemu: make sure capability probing process can start

2014-10-09 Thread Daniel P. Berrange
On Thu, Oct 09, 2014 at 09:58:30AM +0200, Martin Kletzander wrote: > When daemon is killed right in the middle of probing a qemu binary for > its capabilities, the VM is left running. Next time the daemon is > starting, it cannot start qemu process because the one that's already > running does hav

[libvirt] [PATCH 1/2] qemu: make sure capability probing process can start

2014-10-09 Thread Martin Kletzander
When daemon is killed right in the middle of probing a qemu binary for its capabilities, the VM is left running. Next time the daemon is starting, it cannot start qemu process because the one that's already running does have the pidfile flock()'d. Reported-by: Wang Yufei Signed-off-by: Martin K