Re: [libvirt] [PATCH 1/2] snapshot: add REVERT_FORCE to API

2011-10-04 Thread Laine Stump
On 09/30/2011 02:52 PM, Eric Blake wrote: Although reverting to a snapshot is a form of data loss, this is normally expected. However, there are two cases where additional surprises (failure to run the reverted state, or a break in connectivity to the domain) can come into play. Requiring

Re: [libvirt] [PATCH 1/2] snapshot: add REVERT_FORCE to API

2011-10-04 Thread Eric Blake
On 10/04/2011 01:24 PM, Laine Stump wrote: - if (virDomainRevertToSnapshot(snapshot, flags) 0) + result = virDomainRevertToSnapshot(snapshot, flags); + if (result 0 force + last_error-code == VIR_ERR_SNAPSHOT_REVERT_RISKY) { + flags |= VIR_DOMAIN_SNAPSHOT_REVERT_FORCE; Are you not adding the

[libvirt] [PATCH 1/2] snapshot: add REVERT_FORCE to API

2011-09-30 Thread Eric Blake
Although reverting to a snapshot is a form of data loss, this is normally expected. However, there are two cases where additional surprises (failure to run the reverted state, or a break in connectivity to the domain) can come into play. Requiring extra acknowledgment in these cases will make it