Re: [libvirt] [PATCH 1/2] socket: preserve real errno when socket/bind calls fail

2018-07-25 Thread Daniel P . Berrangé
On Tue, Jul 24, 2018 at 05:51:50PM +0200, Jiri Denemark wrote: > On Tue, Jul 24, 2018 at 15:18:09 +0100, Daniel P. Berrangé wrote: > > When reporting socket/bind failures we want to ensure any fatal error > > reported is as accurate as possible. We'll prefer reporting a bind() > > errno over a

Re: [libvirt] [PATCH 1/2] socket: preserve real errno when socket/bind calls fail

2018-07-24 Thread Jiri Denemark
On Tue, Jul 24, 2018 at 15:18:09 +0100, Daniel P. Berrangé wrote: > When reporting socket/bind failures we want to ensure any fatal error > reported is as accurate as possible. We'll prefer reporting a bind() > errno over a socket() errno, because if socket() works but bind() fails > that is a

[libvirt] [PATCH 1/2] socket: preserve real errno when socket/bind calls fail

2018-07-24 Thread Daniel P . Berrangé
When reporting socket/bind failures we want to ensure any fatal error reported is as accurate as possible. We'll prefer reporting a bind() errno over a socket() errno, because if socket() works but bind() fails that is a more significant event. Signed-off-by: Daniel P. Berrangé ---